incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Fisher <dave2w...@comcast.net>
Subject Re: [VOTE] Apache AriaTosca Release 0.2.0
Date Thu, 11 Jan 2018 01:35:40 GMT

> On Jan 10, 2018, at 5:29 PM, Tal Liron <tal@cloudify.co> wrote:
> 
> The Python package name does not contain the version. In Python tooling
> (setuptools, distutils, pip) you specify the dependency as a combination of
> a package name and a version qualifier (specific, list, range, etc.).
> 
> (There are a few rare exceptions in which the version number becomes part
> of the package name, usually as part of a project fork. For example:
> "Jinja2".)
> 
> The package file names do contain a version number, and actually follow a
> strict naming convention. There are a few common packaging formats
> (tarballs, eggs, wheels) with their own naming conventions, which including
> the version, and sometimes which Python versions they support, and which
> platform they are pre-compiled for. Example of a wheel filename:
> 
> ronin-1.1.1-py2.py3-none-any.whl
> 
> The biggest problem I can see in adding "-incubating" to the Python package
> name is that when the project graduates from incubation all dependent
> projects would have to be updated with the new name in order to continue
> getting updates from the project. For example, if a project depends on
> "apache-airflow-incubator>1.9.0" but the then version 1.9.1 is released as
> "apache-airflow" due to graduation, the update will not arrive.
> 
> I would consider it a major disruption for a Python package to change its
> name and hope the ASF considers not adding "-incubating" to Python package
> names.

Would a version like "1.9.0.incubating" be feasible?

Regards,
Dave

> 
> On Wed, Jan 10, 2018 at 7:11 PM, John D. Ament <johndament@apache.org>
> wrote:
> 
>> On Wed, Jan 10, 2018 at 7:53 PM Tal Liron <tal@cloudify.co> wrote:
>> 
>>> The line mentioned is not in NOTICE. The line is specifically a comment
>> in
>>> a file used to download/install a 3rd party product on the cloud. I truly
>>> think we are in the clear here.
>>> 
>>> Re: Python packaging. Apache Airflow is also in incubation and also, like
>>> AriaTosca, does not have the "-incubating" in its Python package name.
>>> 
>>> I think it's time we had some clarity here regarding policy and apply it
>> to
>>> all projects. AriaTosca would of course comply with whatever is decided.
>>> 
>> 
>> Actually, if anything, my lessons learned from the early days of AT have
>> helped us provide more input to projects like Airflow.  We haven't dealt
>> with a lot of python projects, especially those published via pypi.  So
>> please help us understand factually what are the issues.
>> 
>> When we publish a package, it should be named
>> apache-projectname-version-incubating.  Does the way pypi work mean that
>> the version is "version-incubating" or does pypi support qualifiers?
>> 
>> 
>>> 
>>> On Wed, Jan 10, 2018 at 6:44 PM, sebb <sebbaz@gmail.com> wrote:
>>> 
>>>> On 10 January 2018 at 17:10, Tal Liron <tal@cloudify.co> wrote:
>>>>> John, the line is relevant. The service template in question is used
>> to
>>>>> install and deploy Clearwater IMS.
>>>> 
>>>> The NOTICE and LICENSE files are ONLY for files that are actually
>>>> included in the release archive.
>>>> 
>>>>> I believe users should know what they are installing.
>>>> 
>>>> Yes, but not in NOTICE.
>>>> There should be a prompt to ask the user whether it's OK to install the
>>>> code.
>>>> The license can be mentioned at that point.
>>>> 
>>>> A separate issue is whether the dependency on the GPL code is OK.
>>>> Will the product run without the download?
>>>> The general rule is that Cat X dependencies (includes GPL) must be
>>>> optional.
>>>> 
>>>> http://www.apache.org/legal/resolved.html#optional
>>>> 
>>>>> I don't know if we can include a suffix easily, and wonder why need
>> to
>>>>> change it now -- it will make it harder for users to upgrade if there
>>> are
>>>>> two different package names.
>>>>> 
>>>>> On Wed, Jan 10, 2018 at 10:57 AM, John D. Ament <
>> johndament@apache.org
>>>> 
>>>>> wrote:
>>>>> 
>>>>>> On Wed, Jan 10, 2018 at 2:35 AM Tal Liron <tal@cloudify.co>
wrote:
>>>>>> 
>>>>>>> Hi Justin,
>>>>>>> 
>>>>>>> Project Clearwater is GNU GPLv3, however it is not included in
>> this
>>>>>>> distribution. These two files are Apache licensed. The line you
>>> quote
>>>> is
>>>>>>> merely informational.
>>>>>>> 
>>>>>> 
>>>>>> That line should be removed, as it is not relevant to the release
>>>> contents
>>>>>> then.
>>>>>> 
>>>>>> 
>>>>>>> 
>>>>>>> That tarball and wheel file you are looking at are not Apache
>>>>>>> distributions, but rather Python packages. Are you sure they
need
>> to
>>>> have
>>>>>>> "-incubating" in the name?
>>>>>>> 
>>>>>> 
>>>>>> As far as I can tell, this is a limitation of the pypi packages,
and
>>> the
>>>>>> source release includes the proper naming.  I see that in the 0.1.1
>>>>>> release, this issue didn't come up.  Do you know if we can include
a
>>>> suffix
>>>>>> this like, or would pypi treat this as a part of the version #?
>>>>>> 
>>>>>> 
>>>>>>> 
>>>>>>> On Wed, Jan 10, 2018 at 1:15 AM, Justin Mclean <
>> justinmclean@me.com
>>>> 
>>>>>>> wrote:
>>>>>>> 
>>>>>>>> Hi,
>>>>>>>> 
>>>>>>>> -1 binding as releases don't have incubating in the name.
>>>>>>>> apache-ariatosca-0.2.0.tar.gz
>>>>>>>> apache_ariatosca-0.2.0-py2-none-any.whl
>>>>>>>> 
>>>>>>>> Also can you confirm the license of these two files  [1][2]
as
>>> they
>>>>>>>> contain:
>>>>>>>> "Project Clearwater is an open-source IMS core, developed
by
>>>> Metaswitch
>>>>>>>> Networks and released under the GNU GPLv3."
>>>>>>>> 
>>>>>>>> I checked:
>>>>>>>> - incubating missing in release name
>>>>>>>> - signatures and hashes correct
>>>>>>>> - DISCLAIMER exists
>>>>>>>> - LICENSE and NOTICE correct
>>>>>>>> - no unexpected binaries in source release
>>>>>>>> - all source files have ASF headers
>>>>>>>> - couldn’t compile from source but probably my environment
>>>>>>>> 
>>>>>>>> Thanks,
>>>>>>>> Justin
>>>>>>>> 
>>>>>>>> 1. apache-ariatosca-0.2.0-incubating.tar/apache-
>>>>>>>> ariatosca-0.2.0-incubating/examples/clearwater/
>>>>>>>> clearwater-live-test-existing.yaml
>>>>>>>> 2. apache-ariatosca-0.2.0-incubating.tar/apache-
>>>>>>>> 
>>>>>>> ariatosca-0.2.0-incubating/examples/clearwater/
>>>>>> clearwater-single-existing.
>>>>>>>> yaml
>>>>>>>> ------------------------------------------------------------
>>>> ---------
>>>>>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.
>> apache.org
>>>>>>>> For additional commands, e-mail:
>>> general-help@incubator.apache.org
>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>> 
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>> 
>>>> 
>>> 
>> 


Mime
View raw message