incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Airflow 1.9.0
Date Wed, 20 Dec 2017 04:44:03 GMT
Hi,

+1 (binding) but there’s a few things to fix up for the next release.

I checked:
- incubating in name
- signatures ands hashes fine
- disclaimer exits
- please fix year in notice ("2016 and onwards” makes it a little bard to work out when
copyright would expire)
- LICENSE is OK but some license texts are missing i.e. Bootstrap Toggle, normalize.css, parallel.js.
Note that in order to comply with the terms of the the licenses the full text of the license
MUST be included.
- also note that ace and d3 are under a  BSD 3 clause not BSD 2 clause
- A large number of files are missing the correct ASF header. [4] (see below)
- No unexpected binary files

Some instructions on how to compile the source code would be useful.

Re incorrect header not perfect but shows scope of the issue:
$ find . -name "*.*" -exec grep "contributor license" {} \; -print | wc
     146     758    8300
$ find . -name "*.*" -exec grep "http://www.apache.org/licenses/LICENSE-2.0" {} \; -print
| wc
    1148    1674   49394

Thanks,
Justin

1. /airflow/contrib/hooks/bigquery_hook.py
2. /airflow/utils/dag_processing.py
3. airflow/contrib/operators/bigquery_operator.py
4. https://www.apache.org/legal/src-headers.html#headers
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message