incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <justinmcl...@me.com>
Subject Re: [VOTE] Apache MXNet (incubating) 0.11.0 release RC3
Date Wed, 30 Aug 2017 02:30:32 GMT
Hi,

Sorry the send button got pressed a bit too quickly there.

+1 (binding) but there a few outstanding things that need to be fixed IMO before the next
release.

I checked:
- incubating in name
- signature and hashes good
- DISCLAIMER exists
- NOTICE may have wrong year range (should only be 2017?)
- LICENSE has some minor issues and missing a few permissive licenses
- There’s a number of issue with headers on files with a large number of files missing the
standard ASF header or an Apache license header. Please fix for next release.
- Didn’t try to compile as there’s doesn’t seem to be any instruction on how to do so.
Would be nice if this was provided in the README.

License is missing
- BSD license for this file [4]
- MIT licensed JQuery and Sizzle.js [5]
- This BSD licensed file [6]
- Boost Software licensed file [7]
- This BSD licensed files [8][9]

Some minor issues:
- While a number of file (around 50 odd) do have "Copyright (c) 2016 by Contributors” they
don’t have a full Apache licensed header please fix this in the next release. More files
exist with other years and without the correct header.
- This license file may be a little misleading [1] where its apache license but also claims
“All rights reserved”. I notice this in a number of other places as well.
- A number of Apache licenses have incorrect appendixes with the copyright line filled in
e.g. [2]
- This file may incorrect have an ASF header on it [3]

Also the README has a large number of links to http://mxnet.io I assume this will be changed
during incubation?

Thanks,
Justin

1. ./src/operator/contrib/ctc_include/LICENSE
2../dlpack/LICENSE
3. ./example/image-classification/predict-cpp/image-classification-predict.cc
4. ./docs/_static/searchtools_custom.js
5. ./docs/_static/jquery-1.11.1.js
6.  ./cub/test/mersenne.h
7. ./cmake/Modules/FindJeMalloc.cmake
8. ./dmlc-core/cmake/Modules/FindCrypto.cmake
9. ./nnvm/dmlc-core/cmake/Modules/FindCrypto.cmake




---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message