incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Apache HTrace 4.3.0 incubating release (rc3)
Date Sun, 11 Jun 2017 00:27:06 GMT
Hi,

+1 binding

I checked:
- incubating in name
- disclaimer exists
- NOTICE has some extra text that can be removed
- LICENSE has a minor issue
- No unexpected binaries
- All source file have ASF headers
- Didn’t compile as Maven 3.0.4 is required, would be good to not have this requirement.

A couple of minor issues:
-This file [1] has a copyright line when it probably shouldn’t.
- License is missing license for normalise.css

Thanks,
Justin

1. ./bin/gen_thrift.sh
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message