incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Impala 2.9.0 release candidate 1
Date Sat, 10 Jun 2017 23:57:11 GMT
Hi,

+1 (binding)

I checked:
- incubating in name
- hashes and signatures right
- disclaimer exists
- NOTICE good
- LICENSE has a few minor issues
- no unexpected binary files
- source files have ASF headers
- didn’t they compiling as only supported on linux

LICENSE has a couple of very minor issue:
- [1] is missing from license.
- [2] probably shouldn't have an ASF headers on it and be mentioned in LICENSE as it contains
BSD licensed code.
- This file [3] contains public domain license SHA-1 code by Steve Reid this shod be added
to LICENSE.

Thanks,
Justin

1 ./shell/pkg_resources.py
2. ./cmake_modules/FindProtobuf.cmake
3. ./be/src/thirdparty/squeasel/squeasel.c



Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message