Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2B8AD200C27 for ; Sun, 12 Feb 2017 00:07:14 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 23058160B5D; Sat, 11 Feb 2017 23:07:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 688CA160B5B for ; Sun, 12 Feb 2017 00:07:13 +0100 (CET) Received: (qmail 4042 invoked by uid 500); 11 Feb 2017 23:07:12 -0000 Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@incubator.apache.org Delivered-To: mailing list general@incubator.apache.org Received: (qmail 4031 invoked by uid 99); 11 Feb 2017 23:07:12 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Feb 2017 23:07:12 +0000 Received: from mail-yw0-f181.google.com (mail-yw0-f181.google.com [209.85.161.181]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id D23641A002B for ; Sat, 11 Feb 2017 23:07:11 +0000 (UTC) Received: by mail-yw0-f181.google.com with SMTP id l19so36788502ywc.2 for ; Sat, 11 Feb 2017 15:07:11 -0800 (PST) X-Gm-Message-State: AMke39lo8PsWt6vZEjyhwRutOOUgVMNfpDGzhs0FSAPOxgpPD2RB+fboOUyFSMAtKRf+CpsEof6XxZg5+l92Ow== X-Received: by 10.13.222.193 with SMTP id h184mr11976707ywe.173.1486854431179; Sat, 11 Feb 2017 15:07:11 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: "John D. Ament" Date: Sat, 11 Feb 2017 23:07:00 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [VOTE] Release apache-singa-incubating-1.1.0 (RC1) To: general@incubator.apache.org Content-Type: multipart/alternative; boundary=94eb2c07d4123414d605484946c5 archived-at: Sat, 11 Feb 2017 23:07:14 -0000 --94eb2c07d4123414d605484946c5 Content-Type: text/plain; charset=UTF-8 Ok, based on the information provided I'm changing to a +1. We should figure out if glog can really be considered acceptable, but if it is confirmed as optional then its moot per the discussion in https://issues.apache.org/jira/browse/LEGAL-280 John On Fri, Feb 10, 2017 at 9:46 AM Wang Wei wrote: > Hi all, > > We made glog an optional dependency in this ticket > https://issues.apache.org/jira/browse/SINGA-166 and the commit history is > here > > https://github.com/apache/incubator-singa/commits/master/include/singa/utils/logging.h > > I removed glog from .travis.yml in this PR https://github.com/apache/ > incubator-singa/pull/306 > > And it passed all unit tests https://travis-ci.org/apache/ > incubator-singa/builds/200221600 > > I think the above links can confirm that glog is an optional dependency of > Singa. > Please let us know if we need to provide other information. > > Thanks. > > Best, > Wei > > > On Fri, Feb 10, 2017 at 11:04 AM, Justin Mclean > wrote: > > > Hi, > > > > Changing my vote to be also -1 (binding) until the license / dependancy > > issue sorted, but everything else looks good. > > > > Thanks, > > Justin > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org > > For additional commands, e-mail: general-help@incubator.apache.org > > > > > --94eb2c07d4123414d605484946c5--