Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
From: Justin Mclean <justin@classsoftware.com>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_94718293-F77A-4314-914C-DB23D8C96046"
Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\))
Subject: Re: Binary file inclusion (was [VOTE] Apache Toree (incubating)
 0.1.0-rc4 as 0.1.0)
Date: Mon, 23 Jan 2017 19:19:07 +1100
References: <CAEYw2Z41rx4dmkenmoehMct2P6ybBYLsCUq0san5yOhsn8xM0w@mail.gmail.com>
 <CAGU5spfQ+8Qstbqu8tKJYZjuA-dLcV9kvJNBSewZWD4bbvCzig@mail.gmail.com>
 <9666dd86-4f30-cca0-35ea-f707ee8305b0@gmail.com>
 <CAEYw2Z5w9atKRnPWQ2=GpfJmPyEG2D7JNFs260WGiru5bbTkKA@mail.gmail.com>
 <CAGU5spej=qp+dXOoo4PmB7RTK_CV+Wy9_ttLOeGPoUW=bHBuRA@mail.gmail.com>
 <27ce97ae-ffe6-a09c-e4ca-09b2b333b87f@gmail.com>
 <9574D7BE-56E3-4228-BC06-62F9856E4E13@classsoftware.com>
 <CAOqetn-r_YnpGoySCkeO+CiDZivr=vA6VcsTQo3BNdtYM59iow@mail.gmail.com>
 <CAAS6=7hVW9gn5pRC9C6U9oOANXrA8LyzX8j+e-raU1u05w31ZA@mail.gmail.com>
 <CAOqetn_NHZW1TGZgbyY66ToEyKkTD5iujAKZR-bEshbV6pkUbQ@mail.gmail.com>
 <CAAS6=7hEo2Ddr8rm6d3HG8gZBxD7g14OC-Sr_R+k5WQLwe=+hw@mail.gmail.com>
 <CAOqetn9v+mzw1HkZUmGA+nu4PZ9LX49pbEij8Uq0gPVjDF4TUA@mail.gmail.com>
To: general@incubator.apache.org
In-Reply-To: <CAOqetn9v+mzw1HkZUmGA+nu4PZ9LX49pbEij8Uq0gPVjDF4TUA@mail.gmail.com>
Message-Id: <C79653D3-F645-4EAF-A335-A7EB3301B13E@classsoftware.com>
archived-at: Mon, 23 Jan 2017 08:19:22 -0000

--Apple-Mail=_94718293-F77A-4314-914C-DB23D8C96046
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hi,

> My interpretation of the term "compiled code" means compiled versions =
of the source code within the package.

So how is including a jar in a source release to which there is no =
source code included (or even a pointer to that code that I can see) =
actually open source software?

Given this can be easily resolved by including the code and not the jars =
/ changing the build process why is there a need to include the compile =
code in the source release?

But lets assume we allow this in a source release. It seems minor =
(it=E2=80=99s only test code as you say), but once we do allow jars / =
compiled code in source releases where do we draw the line? Is it OK to =
include gradle wrapper jars for instance? Or 3rd party dependancy jars? =
Or our compiled source code as well? All of these situations have =
resulted in -1 votes on incubator (and TLP) releases before.

> I suspect that Toree did all of this in their
> release package because Apache Spark was already doing that, and they =
were
> leveraging spark functionality, and if a TLP is doing it, it must be =
correct.

Just because it's being done by a TLP doesn=E2=80=99t automatically make =
it correct :-)

Thanks
Justin=

--Apple-Mail=_94718293-F77A-4314-914C-DB23D8C96046--