incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Senkbeil <chip.senkb...@gmail.com>
Subject Re: [VOTE] Apache Toree (incubating) 0.1.0-rc4 as 0.1.0
Date Mon, 23 Jan 2017 17:44:06 GMT
Hi everyone,

Based on feedback we've received regarding issues with this release
candidate, we are preparing a new candidate to address those issues.

- The following test jars have been replaced with code to compile source
and build jars at runtime to provide the same test functionality:
    - ScalaTestJar.jar
    - TestJar.jar
    - TestJar2.jar
- The sparkr_bundle.tar.gz archive has been removed. We were maintaining a
fork of SparkR that added functionality we needed to support a SparkR
interpreter. We have remedied this to use private SparkR APIs directly.
- Likewise, the sparktestjar_2.10-1.0.jar file has been removed since we no
longer need to maintain a fork of SparkR.

Our build system required sbt to build our source code and we currently
have some logic that depends on you being inside a git project. We didn't
consider that the source release was not a git project. We'll have to look
into rectifying that. With regard to sbt, Apache Spark includes a build
script for sbt here: https://github.com/apache/spark/blob/master/build/sbt Can
we grab that script and use it? That would work to fix the problem of not
having sbt installed.

Justin, with regard to your comments about the LICENSE and NOTICE files:
- The copyright date is wrong in the NOTICE file as you said. My fault for
not changing it after the new year. I'll address that.
- With regard to the copyrights being in the LICENSE file, that should only
be happening for our binary distribution. It's a bug in our build that is
also including the copyrights in the source distribution. I'll remedy the
source version to not include the copyrights in the LICENSE file. We do
still need those in the binary distribution, correct? We've been told a
variety of items to include and not include, so I want to make sure we get
them right.
- With the removal of the SparkR fork from our code, there should be no 3rd
party source code in our release for the next candidate; so, no worries
about ASF headers there.
- I never noticed the \n literal character appearing in our generated
LICENSE and NOTICE files. I'll address that as well.

As for the failure to build with make: *** No rule to make target
`etc/legal/LICENSE_extras, we are planning to get rid of that target from
our Makefile as we are not generating that file. Is there a specific place
we should put the extra license information (etc/legal/LICENSE_extras is
where it lives now in our repo)? We were not including the file in our
source distribution because it was being concatenated with the LICENSE
directly as part of packaging the source distribution (which should only be
done for binary distributions?). Should people be able to build the binary
distribution LICENSE, NOTICE, etc from source?

Signed,
Chip Senkbeil

On Fri, Jan 13, 2017 at 4:43 PM Chip Senkbeil <chip.senkbeil@gmail.com>
wrote:

> Please vote on releasing the following candidate as Apache Toree
> (incubating) version 0.1.0.
>
> A vote on this release has passed within the Toree PPMC.
>
> PPMC vote result thread:
>
> https://lists.apache.org/thread.html/5589e9b729333b0d95ccea639fcacf03fdc3d9480aaeb8e80399ad35@
> <dev.toree.apache.org>
>
> PPMC vote thread:
>
> https://lists.apache.org/thread.html/493874de453d9ccbdbc3aecc2f527dea6af82d657104732d726e07f9@
> <dev.toree.apache.org>
>
> The tag to be voted on is v0.1.0-rc4
> (1d526954ecaba1d5dc0f40ec555dd598b2b11df7), located here:
>
> https://github.com/apache/incubator-toree/commit/1d526954ecaba1d5dc0f40ec555dd598b2b11df7
>
> All distribution packages, including signatures, digests, etc. can be
> found at:
> https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc4/
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/chipsenkbeil.asc
>
> The list of keys associated with Toree is available at:
> https://people.apache.org/keys/group/toree.asc
>
> Staging artifacts can be found at:
> https://repository.apache.org/content/repositories/orgapachetoree-1002/
>
> Please vote on releasing this package as Apache Toree 0.1.0-incubating!
>
> The vote is open for 72 hours - until Monday, January 16, at 22:43 UTC -
> and passes if a majority of at least 3 +1 IPMC votes are cast.
>
> [ ] +1 Release this package as Apache Toree 0.1.0-incubating
> [ ] -1 Do not release this package because ...
>
> To learn more about Apache Toree, please see
> http://toree.incubator.apache.org/
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message