Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
MIME-Version: 1.0
Sender: shaposhnik@gmail.com
In-Reply-To: <CAOSe2yvFknZcihcgpSVh=93Sd2OtpV91cCzZz2dyY94dfugJ8w@mail.gmail.com>
References: <CAOSe2ytn3DSfc7sphzJ9YYvCM5FuUOiBByM60z_bvio2F69o2g@mail.gmail.com>
 <E4A4287E-8A78-4A61-9666-0F111BFA9D7C@classsoftware.com> <CA+ULb+vcXGe5C+yiXdGS2gTD3vnpcs1e=oW5D6hffLSt+mOn0A@mail.gmail.com>
 <CAOSe2yvFknZcihcgpSVh=93Sd2OtpV91cCzZz2dyY94dfugJ8w@mail.gmail.com>
From: Roman Shaposhnik <roman@shaposhnik.org>
Date: Wed, 28 Dec 2016 17:01:58 -0800
Message-ID: <CA+ULb+uvzD9n4nV=vPZ-wayNQcdg+cB9hDzUPVAj0xaJXXXYZQ@mail.gmail.com>
Subject: Re: [VOTE] Release Apache Fineract 0.5.0 (incubating)
To: "general@incubator.apache.org" <general@incubator.apache.org>
Content-Type: text/plain; charset=UTF-8
archived-at: Thu, 29 Dec 2016 01:02:14 -0000

On Wed, Dec 21, 2016 at 8:52 PM, Nazeer Shaik <nazeer1100126@apache.org> wrote:
> Hi Roman, thank you for reviewing the release.
>
> * the format of your hashes is not super convenient for an automatic
> comparison, being compatible with command line tools is probably a
> good idea
> [Nazeer] Can you give some more details please. May be a link to some
> Apache projects will help us to change hash formats :-)

Anything that lends itself to a direct diff/cmp is a good choice. E.g.:
    http://www-eu.apache.org/dist/geode/1.0.0-incubating/

>   * I feel that including both LICENSE and LICENSE.md may confuse people
> [Nazeer] Will work on this in next releases

Great! Do you have a JIRA filed for this by any chance?

>   * I am really happy you've integrated rat check into the build, but
> it would be really nice if you could make it available from the top
> level folder
> [Nazeer] rat is configured in such way, it will check all directories and
> files from top level directory. I feel current approach is OK. Please let
> us know otherwise

Well, it took me some time to find out how to run it. This is not a huge
deal, but anything you can do to reduce surprise (like a lot of folks here,
I expect gradle rat to do the right thing when I run it from the top level)
will help you get more folks review your release quicker. IOW, this is not
about some kind of a policy, but rather making your source code base
friendly to reviewers (and users!).

>   * I seems weird that you release war file in a tarball instead of a Maven
> repo
> [Nazeer] Will start a discussion with Fineract community and will take
> their opinion also.

Great!

Thanks,
Roman.

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org