Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
Subject: Re: [VOTE] Release Apache Mynewt 1.0.0-b1-incubating-rc2
To: general@incubator.apache.org
References: <20161203024311.GW3011@pseudoephedrine.nightmare-heaven.no-ip.biz>
 <6821E2AA-22D2-4E7E-8796-3A92582911CA@classsoftware.com>
 <B041541D-9F91-4204-A42B-3D2A398B515C@apache.org>
From: Ian Dunlop <ianwdunlop@gmail.com>
Message-ID: <693797c5-6010-8254-7db7-cbac1f4a1203@gmail.com>
Date: Wed, 7 Dec 2016 12:40:35 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <B041541D-9F91-4204-A42B-3D2A398B515C@apache.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="7xlmCTEj6uehlTjoEbFUmJCJT9rTn4PbC"
archived-at: Wed, 07 Dec 2016 12:40:43 -0000

--7xlmCTEj6uehlTjoEbFUmJCJT9rTn4PbC
Content-Type: multipart/mixed; boundary="sXvjHA5GLa8uX5Rr0Qu0ue1bVS8ejSq98";
 protected-headers="v1"
From: Ian Dunlop <ianwdunlop@gmail.com>
To: general@incubator.apache.org
Message-ID: <693797c5-6010-8254-7db7-cbac1f4a1203@gmail.com>
Subject: Re: [VOTE] Release Apache Mynewt 1.0.0-b1-incubating-rc2
References: <20161203024311.GW3011@pseudoephedrine.nightmare-heaven.no-ip.biz>
 <6821E2AA-22D2-4E7E-8796-3A92582911CA@classsoftware.com>
 <B041541D-9F91-4204-A42B-3D2A398B515C@apache.org>
In-Reply-To: <B041541D-9F91-4204-A42B-3D2A398B515C@apache.org>

--sXvjHA5GLa8uX5Rr0Qu0ue1bVS8ejSq98
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

Hello,

+1 non-binding

I checked:

 - incubating in name

 - hashes correct

 - Can compile from source for newt and blinky. All tests run for core.

Here are a few things I noticed when checking that don't affect the
release but might help if added to docs in future:

1) Should point out type of sha sum somehow. Perhaps in the .sha file.
Could call it .sha512
2) http://mynewt.apache.org/os/get_started/introduction/ referenced in
blinky README is missing. Found introduction at os/introduction and
build instructions via os/get_started/get_started/ which took me to
http://mynewt.apache.org/os/get_started/native_tools/
3) In stage 4 of build newt on
http://mynewt.apache.org/os/get_started/native_tools/ you have to export
the newt path before you can run it. I think this needs to be pointed
out just after the build instructions, not in the bracketed part after
telling you to run 'newt'.
4) export newt=3D"go run $GOPATH/mynewt.apache.org/newt/newt/newt.go"
seems wrong on my machine since GOPATH would need /src included. Should
possibly be export newt=3D"go run
$GOPATH/src/mynewt.apache.org/newt/newt/newt.go"

Not everything seems to work with newt test all, here is what happened
for me:

blinky - $newt test all - 'no testable packages found'. Installed with
$newt install && $newt build my_blinky_sim
core - $newt test all - all tests passed. I wasn't sure if you could
actually build this from the root directory or had to build each
individual project.
newt - $newt test all - 'Error: No project file found!' I successfully
built it with ./build.sh

Cheers,

Ian

On 05/12/16 02:37, Sterling Hughes wrote:
> +1 binding.
>
> On 4 Dec 2016, at 16:58, Justin Mclean wrote:
>
>> Hi,
>>
>> +1 binding
>>
>> I checked:
>> - incubating in name
>> - signatures and hashes correct
>> - DISCLAIMER exists
>> - LICENSE and NOTICE good
>> - All source file have apache headers
>> - No unexpected binaries
>> - Can compile from source
>>
>> A couple of minor things re compilation which other people may run int=
o:
>> 1. It would be good to have better compile instructions especially
>> for the core package.
>> 2. It seems that blinky expects gcc-5 in /usr/local/bin/ and I only
>> had gcc-6 installed and an older version of gcc in /usr/bin/gcc
>> 3. A newt build all in core does nothing, but a newt test all goes
>> off and compiles and runs the tests. Is that expected? How do you
>> just build core?
>>
>> Thanks,
>> Justin
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>


--sXvjHA5GLa8uX5Rr0Qu0ue1bVS8ejSq98--

--7xlmCTEj6uehlTjoEbFUmJCJT9rTn4PbC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJYSANDAAoJEPK45GBX+Cy5FdEH/ijfZyjkhJV+xpl+AyQePQOx
oV4lzcyOoO2UgZRTgcAuxotUM0vnAlk1Pxli69rXVsAl8/2+sLGzlsypHn/od99A
K495FgC/cKoKDLc3RRFqN8gyFhi9bH4Rd931xeo5F3hMfTaJjGAp8DuqW1yl0Gd5
43/7VPgKL/HxEUN55KbTGLS4dQbffCSqqCqee7s6R1GtisItiitkpN8URrkkUjcj
C1rWxGeDyl/KFYqI7yple8MgUgDopPrrY05l60aukaYv6tACeNvPMI6ZXpl9OtOS
FCNP/qy6n9wZttqIe+uLVDpnKVqYexOQrzKNke/7UGXU2jZaOw/DvYb0+6cDaQU=
=GEKI
-----END PGP SIGNATURE-----

--7xlmCTEj6uehlTjoEbFUmJCJT9rTn4PbC--