incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache Fineract 0.5.0 (incubating)
Date Mon, 19 Dec 2016 22:52:44 GMT
Hi,

+1 binding

I checked:
- signatures and hashes correct
- incubating in release names
- DISCLAIMER exists in source
- LICENSE and NOTICE good
- All source files have ASF headers
- No unexpected binary files
- Can compile from source

I would remove the list of software included in the binary release from the source release
LICENSE file. It’s fine to have two different license files. The LICENSE may also be missing
a license for jquery [1]?

The convenience binary file is missing LICENSE, NOTICE and DISCLAIMER in the top level, however
the LICENSE and NOTICE file is inside the war and look correct. Can you fix this in the next
release please.

Thanks,
Justin

1. ./docs/system-architecture/css/toc-0.1.2/example/jquery.js


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message