incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nazeer Shaik <nazeer1100...@apache.org>
Subject Re: [VOTE] Release Apache Fineract 0.5.0 (incubating)
Date Thu, 29 Dec 2016 12:06:12 GMT
Thank you Romain. I have raised JIRA issue today and added all review
comments of this release. Please find the jira details below
https://issues.apache.org/jira/browse/FINERACT-357

Thanks,
Nazeer

On Thu, Dec 29, 2016 at 6:31 AM, Roman Shaposhnik <roman@shaposhnik.org>
wrote:

> On Wed, Dec 21, 2016 at 8:52 PM, Nazeer Shaik <nazeer1100126@apache.org>
> wrote:
> > Hi Roman, thank you for reviewing the release.
> >
> > * the format of your hashes is not super convenient for an automatic
> > comparison, being compatible with command line tools is probably a
> > good idea
> > [Nazeer] Can you give some more details please. May be a link to some
> > Apache projects will help us to change hash formats :-)
>
> Anything that lends itself to a direct diff/cmp is a good choice. E.g.:
>     http://www-eu.apache.org/dist/geode/1.0.0-incubating/
>
> >   * I feel that including both LICENSE and LICENSE.md may confuse people
> > [Nazeer] Will work on this in next releases
>
> Great! Do you have a JIRA filed for this by any chance?
>
> >   * I am really happy you've integrated rat check into the build, but
> > it would be really nice if you could make it available from the top
> > level folder
> > [Nazeer] rat is configured in such way, it will check all directories and
> > files from top level directory. I feel current approach is OK. Please let
> > us know otherwise
>
> Well, it took me some time to find out how to run it. This is not a huge
> deal, but anything you can do to reduce surprise (like a lot of folks here,
> I expect gradle rat to do the right thing when I run it from the top level)
> will help you get more folks review your release quicker. IOW, this is not
> about some kind of a policy, but rather making your source code base
> friendly to reviewers (and users!).
>
> >   * I seems weird that you release war file in a tarball instead of a
> Maven
> > repo
> > [Nazeer] Will start a discussion with Fineract community and will take
> > their opinion also.
>
> Great!
>
> Thanks,
> Roman.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message