Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC1
From: Justin Mclean <justin@classsoftware.com>
In-Reply-To: <CANHMhVv-Sw7+Bc_rVHe6hzdB47=4F0mAjzw=pZvL_M0Mi6cmyg@mail.gmail.com>
Date: Mon, 26 Sep 2016 17:39:54 +1000
Content-Transfer-Encoding: quoted-printable
Message-Id: <9F63CB45-770F-43ED-9155-882B7CBCC361@classsoftware.com>
References: <CANHMhVuyjhaF8nQ+Ebwix+afDzEQMgfyzWAx+mFDe5tecoWf1w@mail.gmail.com> <CANHMhVv-Sw7+Bc_rVHe6hzdB47=4F0mAjzw=pZvL_M0Mi6cmyg@mail.gmail.com>
To: general@incubator.apache.org
archived-at: Mon, 26 Sep 2016 07:40:09 -0000

Hi,

+1 binding

I checked:
- incubating in name
- signatures and hashes correct
- DISCLAIMER exists
- LICENSE and NOTICE good
- No unexpected binary in source
- Looks like most if not all files have incorrect ASF headers. The ASF =
header should not include a copyright line [2]. Not that it matters but =
the copyright date range is also incorrect. Please remove in next =
release.
- Can compile from source

Some very minor things:
- would be good if release was signed by an apache email address (not a =
gmail one)
- might want to update the copyright year in this file [1]

It also looks like you may of got ahead of yourself and published the =
release before the incubator vote results and linked to it from your web =
site. Please don=E2=80=99t do that.

Thanks,
Justin

1. =
./samoa-0.4.0-incubating/samoa-api/src/main/java/org/apache/samoa/core/Glo=
bals.java
2. https://www.apache.org/legal/src-headers.html#headers
3. https://www.apache.org/dist/incubator/samoa/0.4.0-incubating/=

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org