Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
From: Flavio Junqueira <fpj@apache.org>
Content-Type: multipart/alternative; boundary="Apple-Mail=_64538281-8C64-4993-BF47-E5178D24B381"
Message-Id: <4551C018-1700-4951-A8B9-ADF56982B561@apache.org>
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC1
Date: Wed, 21 Sep 2016 10:37:04 +0100
References: <CANHMhVuyjhaF8nQ+Ebwix+afDzEQMgfyzWAx+mFDe5tecoWf1w@mail.gmail.com> <CANHMhVv-Sw7+Bc_rVHe6hzdB47=4F0mAjzw=pZvL_M0Mi6cmyg@mail.gmail.com> <C78C4DC2-C77B-45F3-811B-B7004842F09E@gmail.com>
To: general@incubator.apache.org
In-Reply-To: <C78C4DC2-C77B-45F3-811B-B7004842F09E@gmail.com>
archived-at: Wed, 21 Sep 2016 09:37:25 -0000

--Apple-Mail=_64538281-8C64-4993-BF47-E5178D24B381
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

+1

- Built from sources and ran tests
- Checked LICENSE, NOTICE, and DISCLAIMER files
- Checked digests and signatures of the sources zip file and pom
- Ran rat through maven

I have some additional feedback:

- `mvn -Pstorm package` didn't build cleanly for me, I got test errors:

#####################################
Tests in error:=20
  AlgosTest.testCVPReqVHTWithStorm =C2=BB  test timed out after 120000 =
milliseconds
  AlgosTest.testVHTWithStorm =C2=BB  test timed out after 60000 =
milliseconds


Tests run: 4, Failures: 0, Errors: 2, Skipped: 0

[INFO] =
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]=20
[INFO] Apache SAMOA ....................................... SUCCESS [  =
5.003 s]
[INFO] samoa-instances .................................... SUCCESS [  =
2.798 s]
[INFO] samoa-api .......................................... SUCCESS [ =
19.174 s]
[INFO] samoa-test ......................................... SUCCESS [  =
4.978 s]
[INFO] samoa-storm ........................................ FAILURE =
[05:25 min]
[INFO] =
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] =
------------------------------------------------------------------------
[INFO] Total time: 05:58 min
[INFO] Finished at: 2016-09-21T10:12:56+01:00
[INFO] Final Memory: 55M/760M
[INFO] =
------------------------------------------------------------------------
[ERROR] Failed to execute goal =
org.apache.maven.plugins:maven-surefire-plugin:2.18:test (default-test) =
on project samoa-storm: There are test failures.
#####################################

- `mvn apache-rat:check` doesn't run cleanly:

#####################################
[INFO] 55 implicit excludes (use -debug for more details).
[INFO] Exclude: .git/**/*
[INFO] Exclude: **/*.iml
[INFO] Exclude: **/README.md
[INFO] 126 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 13 unknown: 13 =
generated: 0 approved: 81 licence.
[INFO] =
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]=20
[INFO] Apache SAMOA ....................................... FAILURE [  =
8.998 s]
[INFO] samoa-instances .................................... SKIPPED
[INFO] samoa-api .......................................... SKIPPED
[INFO] samoa-test ......................................... SKIPPED
[INFO] samoa-local ........................................ SKIPPED
[INFO] =
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] =
------------------------------------------------------------------------
[INFO] Total time: 19.683 s
[INFO] Finished at: 2016-09-21T10:26:38+01:00
[INFO] Final Memory: 23M/228M
[INFO] =
------------------------------------------------------------------------
[ERROR] Failed to execute goal =
org.apache.rat:apache-rat-plugin:0.10:check (default-cli) on project =
samoa: Too many files with unapproved license: 13 See RAT report in: =
samoa-0.4.0-incubating/target/rat.txt -> [Help 1]
#####################################

> On 20 Sep 2016, at 01:16, Alan Gates <alanfgates@gmail.com> wrote:
>=20
> +1.  Checked the LICENSE, NOTICE, and DISCLAIMER files.  Checked the =
signatures.  Did a build with a clean maven repo.  Checked for binary =
files.  Ran a rat check.
>=20
> As a note there are several files that rat complains about.  Based on =
a quick look I=E2=80=99m not sure it=E2=80=99s possible to add license =
headers to these files.  If it isn=E2=80=99t it would be nice to put =
these in the exception list so that rat succeeds.
>=20
> Alan.
>=20
>> On Sep 19, 2016, at 06:50, Nicolas Kourtellis <nkourtellis@gmail.com> =
wrote:
>>=20
>> Hi all,
>>=20
>> Our new release has been voted from the Apache SAMOA team and we are
>> opening the vote to the incubator email list for testing.
>>=20
>> Please vote on releasing the following release candidate as Apache
>> SAMOA (incubating)
>> version 0.4.0. This release will be the second release for SAMOA in =
the
>> incubator.
>>=20
>> -------------------------------------------------------------
>> The commit to be voted on is in the branch =
"releases/0.4.0-incubating"
>> (commit fc39238dd7d3674c069a8142312da8c1812bc907):
>> https://git1-us-west.apache.org/repos/asf/incubator-samoa/
>> repo?p=3Dincubator-samoa.git;a=3Dcommit;h=3Dfc39238dd7d3674c069a8142312=
da8
>> c1812bc907
>>=20
>> Tag v0.4.0-incubating:
>> https://git1-us-west.apache.org/repos/asf/incubator-samoa/
>> =
repo?p=3Dincubator-samoa.git;a=3Dtag;h=3Daa5bd941ccbed1aabb46b8119049ac1bb=
293c3a2
>>=20
>> Release artifacts are signed with the following key:
>> *https://people.apache.org/keys/committer/nkourtellis.asc
>> <https://people.apache.org/keys/committer/nkourtellis.asc>*
>>=20
>> The staging repository for this release can be found at:
>> https://repository.apache.org/content/repositories/staging/
>> org/apache/samoa/samoa/0.4.0-incubating/
>>=20
>> The developer's version artifacts:
>> =
https://dist.apache.org/repos/dist/dev/incubator/samoa/0.4.0-incubating-rc=
1/
>>=20
>> -------------------------------------------------------------
>>=20
>> Please vote on releasing this package as Apache SAMOA 0.4.0 =
(incubating).
>>=20
>> The vote is open for the next 72 hours and passes if a majority of at =
least
>> three +1 PPMC votes are cast.
>>=20
>> [ ] +1 Release this package as Apache SAMOA 0.4.0 (incubating)
>> [ ] -1 Do not release this package because ...
>>=20
>> I'm +1 on the release.
>>=20
>> Cheers,
>>=20
>> Nicolas
>>=20
>>=20
>>=20
>> --=20
>> Nicolas Kourtellis
>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>=20


--Apple-Mail=_64538281-8C64-4993-BF47-E5178D24B381--