incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stian Soiland-Reyes <st...@apache.org>
Subject Re: [VOTE] Apache BatchEE 0.4-incubating
Date Tue, 27 Sep 2016 10:24:33 GMT
 -0 (non-binding)  -- changes my previous -1 vote after dist/ was populated.

I'm afraid it's not positive vote from me as the unit tests were
failing the build, otherwise I would say +1. But feel free to ignore
this vote :)


-1 .md5 .sha1 missing from dist
+1 valid .asc signature
-1 KEYS file missing
+1 dist matches mvn (same sha1 of batchee-0.4-incubating-source-release.zip)
+1 LICENSE
+0 NOTICE:  should say "Apache Batchee" instead of "Batchee".
Copyright should be 2013-2016 (or so), not just 2016.
-0 DISCLAIMER present - but it says "Apache Sirona" instead of "Apache
BatchEE" (already fixed in git)
+1 no binaries in source archive
+1 mvn apache-rat:check (but jbatch/.../jaxb/* don't have ASF headers)
-1 mvn clean install fails
+1 source kind of match git commit
985047e8cefb46056fcb0bda36af096a0d228fa2 (except LICENSE, NOTICE,
.gitignore, DEPENDENCIES)
-0 git tag missing LICENSE, NOTICE (already fixed in git master)


I would recommend for the JAXB generated files to use the
maven-jaxb-plugin from src/main/xsd so that the generated files end up
in target/generated-sources instead of being checked in.  If they have
to stay (e.g. because they have been modified post generation (uh
oh..)) then they should have the ASF header as they are derived from
the ASF-licensed xsds.


Build failure:

[INFO] BatchEE :: GUI :: JAXRS :: Server .................. FAILURE [ 19.111 s]

Tests run: 9, Failures: 1, Errors: 8, Skipped: 0, Time elapsed: 3.912
sec <<< FAILURE! - in org.apache.batchee.jaxrs.server.RestTest
getRunningExecutions(org.apache.batchee.jaxrs.server.RestTest)  Time
elapsed: 0.772 sec  <<< FAILURE!
java.lang.AssertionError: expected:<500> but was:<404>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at org.apache.batchee.jaxrs.server.RestTest.getRunningExecutions(RestTest.java:82)


and then loads of these:

getJobExecution(org.apache.batchee.jaxrs.server.RestTest)  Time
elapsed: 0.079 sec  <<< ERROR!
org.apache.cxf.jaxrs.client.ServerWebApplicationException:
<html><head><title>Apache Tomcat/7.0.50 - Error
report</title><style><!--H1
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:22px;}
H2 {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:16px;}
H3 {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:14px;}
BODY {font-family:Tahoma,Arial,sans-serif;color:black;background-color:white;}
B {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;}
P {font-family:Tahoma,Arial,sans-serif;background:white;color:black;font-size:12px;}A
{color : black;}A.name {color : black;}HR {color :
#525D76;}--></style> </head><body><h1>HTTP Status 404 -
/batchee-gui/api/batchee/job-execution/0</h1><HR size="1"
noshade="noshade"><p><b>type</b> Status report</p><p><b>message</b>
<u>/batchee-gui/api/batchee/job-execution/0</u></p><p><b>description</b>
<u>The requested resource is not available.</u></p><HR size="1"
noshade="noshade"><h3>Apache Tomcat/7.0.50</h3></body></html>
at org.apache.cxf.jaxrs.client.WebClient.doInvoke(WebClient.java:791)
at org.apache.cxf.jaxrs.client.WebClient.doInvoke(WebClient.java:749)
at org.apache.cxf.jaxrs.client.WebClient.invoke(WebClient.java:365)
at org.apache.cxf.jaxrs.client.WebClient.get(WebClient.java:501)
at org.apache.batchee.jaxrs.server.RestTest.getJobExecution(RestTest.java:117)



For reference:

stain@biggiebuntu:~/src/batchee/dist/0.4-incubating$ sha1sum
batchee-0.4-incubating-source-release.zip
05535de5554b598356f27bdb475853675b80b8b4
batchee-0.4-incubating-source-release.zip


Tested with:
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T16:41:47+00:00)
Maven home: /home/stain/software/maven
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-38-generic", arch: "amd64", family: "unix"

On 26 September 2016 at 07:28, Romain Manni-Bucau <rmannibucau@gmail.com> wrote:
> Hi guys,
>
> batchee community voted the 0.4-incubating good to release, here is the
> time for general@ to vote on it as well
>
> dev@ result:
> http://mail-archives.apache.org/mod_mbox/batchee-dev/201609.mbox/browser
>
> Here is the release note: https://issues.apache.org/jira/secure/ReleaseNote.
> jspa?projectId=12314924&version=12334147
>
> Staging repo: https://repository.apache.org/content/repositories/
> orgapachebatchee-1004/ (yes numbers are funny sometimes ;))
>
> Source zip: https://repository.apache.org/content/repositories/
> orgapachebatchee-1004/org/apache/batchee/batchee/0.4-incubating/batchee-0.4-
> incubating-source-release.zip
>
> Tag: https://github.com/rmannibucau/incubator-batchee/
> tree/batchee-0.4-incubating
>
> My gpg key is in tomee KEYS file (https://dist.apache.org/
> repos/dist/release/tomee/KEYS)
>
> Please VOTE
> [+1] yep
> [+0] don’t care
> [-1] no cause [...]
>
> The VOTE is open for 72h or as needed
>
> Thanks,
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau>
|
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com> | JavaEE Factory
> <https://javaeefactory-rmannibucau.rhcloud.com>



-- 
Stian Soiland-Reyes
http://orcid.org/0000-0001-9842-9718

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message