incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release SAMOA 0.4.0 (incubating) RC1
Date Mon, 26 Sep 2016 07:39:54 GMT
Hi,

+1 binding

I checked:
- incubating in name
- signatures and hashes correct
- DISCLAIMER exists
- LICENSE and NOTICE good
- No unexpected binary in source
- Looks like most if not all files have incorrect ASF headers. The ASF header should not include
a copyright line [2]. Not that it matters but the copyright date range is also incorrect.
Please remove in next release.
- Can compile from source

Some very minor things:
- would be good if release was signed by an apache email address (not a gmail one)
- might want to update the copyright year in this file [1]

It also looks like you may of got ahead of yourself and published the release before the incubator
vote results and linked to it from your web site. Please don’t do that.

Thanks,
Justin

1. ./samoa-0.4.0-incubating/samoa-api/src/main/java/org/apache/samoa/core/Globals.java
2. https://www.apache.org/legal/src-headers.html#headers
3. https://www.apache.org/dist/incubator/samoa/0.4.0-incubating/
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message