incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Apache Pirk 0.1.0-incubating Release
Date Sat, 27 Aug 2016 00:02:23 GMT
Hi,

+1 binding

I checked:
- name included incubating
- signature and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE good
- No unexpected binary files in release
- Can compile from source

I noticed you’ve dropped “apache” from the release artefact names, IMO it’s good to
keep it for branding reasons.

In the export section of the README I’m little confused. The text mentions the JCA  (and
there’s a couple of java.security classes imported in the code) and has a link to the oracle
website [1] but fails to mention the bundled cryptographic code [2] or include a link to the
relevant Apache page. Also out of interest where did [2] original come from?

Thanks,
Justin

1. http://www.oracle.com/us/products/export/eccn-matrix-345817.html
2. ./src/main/java/org/apache/pirk/encryption/Paillier.java
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message