incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suneel Marthi <smar...@apache.org>
Subject Re: [VOTE] Apache Pirk 0.1.0-incubating Release
Date Sat, 27 Aug 2016 01:06:31 GMT
+1 binding

1. License, Disclaimer, Notice look good
2. Compiled source and all tests pass
3. Verified MD5 , SHA1 sigs of artifacts
4. RAT checks pass

On Fri, Aug 26, 2016 at 8:02 PM, Justin Mclean <justin@classsoftware.com>
wrote:

> Hi,
>
> +1 binding
>
> I checked:
> - name included incubating
> - signature and hashes good
> - DISCLAIMER exists
> - LICENSE and NOTICE good
> - No unexpected binary files in release
> - Can compile from source
>
> I noticed you’ve dropped “apache” from the release artefact names, IMO
> it’s good to keep it for branding reasons.
>
> In the export section of the README I’m little confused. The text mentions
> the JCA  (and there’s a couple of java.security classes imported in the
> code) and has a link to the oracle website [1] but fails to mention the
> bundled cryptographic code [2] or include a link to the relevant Apache
> page. Also out of interest where did [2] original come from?
>
> Thanks,
> Justin
>
> 1. http://www.oracle.com/us/products/export/eccn-matrix-345817.html
> 2. ./src/main/java/org/apache/pirk/encryption/Paillier.java
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message