incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anthony Baker <aba...@pivotal.io>
Subject Re: [VOTE] Apache Geode (incubating) 1.0.0-incubating.M3 release
Date Wed, 17 Aug 2016 13:35:34 GMT
Thanks for the review Justin!

We’d really like to close out this release soon and a few more votes would really help.

TIA,
Anthony

> On Aug 16, 2016, at 7:52 AM, Justin Mclean <justin@classsoftware.com> wrote:
> 
> Hi,
> 
> +1 binding
> 
> For the source release I checked:
> - names contain incubating
> - signatures good
> - DISCLAIMER exists
> - LICENSE has a few minor issues (see below)
> - NOTICE is good
> - all files have apache headers (where needed)
> - no unexpected binary files in release
> - can compile from source
> 
> I didn’t check the binary connivence release.
> 
> Minor license issues, can you please fix for the next release:
> - File missing header and missing in LICENSE [1]?
> - LICENSE missing Sizzle.js contained within [2]
> - LICENSE is missing MooTools contained within [3]
> - Only one version of JQuery is mentioned in LICENSE but two versions are bundled [4][5]
> 
> I notice a number of files are Apache 2.0 license but have copyright lines in the header
e.g. "Copyright (C) 2011 Clearspring Technologies, Inc.” is this correct?
> 
> This NOTICE file year needs updating? [6]
> 
> Thanks,
> Justin
> 
> 1. apache-geode-src-1.0.0-incubating.M3/geode-core/src/main/resources/com/gemstone/gemfire/admin/jmx/internal/doc-files/mbeans-descriptors.dtd
> 2. ./geode-pulse/src/main/webapp/scripts/lib/jquery-1.7.2.js
> 3. ./geode-pulse/src/main/webapp/scripts/lib/jit.js
> 4. ./apache-geode-src-1.0.0-incubating.M3/geode-site/website/content/js/jquery-1.10.1.min.js
> 5. ./apache-geode-src-1.0.0-incubating.M3/geode-web-api/src/main/webapp/docs/lib/jquery-1.8.0.min.js
> 6. ./geode-web/src/main/webapp/META-INF/NOTICE
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 


Mime
View raw message