Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
Date: Tue, 26 Jul 2016 17:08:43 +0000 (UTC)
From: Kam Kasravi <kamkasravi@yahoo.com.INVALID>
Reply-To: Kam Kasravi <kamkasravi@yahoo.com>
To: "general@incubator.apache.org" <general@incubator.apache.org>
Message-ID: <1140871260.5991944.1469552923891.JavaMail.yahoo@mail.yahoo.com>
In-Reply-To: <2682C9D7-B595-4AB8-A511-C3A85FFF96DA@classsoftware.com>
References: <CAB9X6p1eezP5c7X=+YY9uo5oc8RVk2pHiB33oAo2rr21DkguMg@mail.gmail.com> <2682C9D7-B595-4AB8-A511-C3A85FFF96DA@classsoftware.com>
Subject: Re: [VOTE] Apache Gearpump (incubating) 0.8.1-RC4 as 0.8.1
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_5991943_356000626.1469552923882"
archived-at: Tue, 26 Jul 2016 17:08:58 -0000

------=_Part_5991943_356000626.1469552923882
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Justin
Again - thanks for your vigilance and time to review RC4.
>All like like there may be license dependancy issues, but I=E2=80=99m not =
familiar enough with sbt and the project to comment. This "sbt dependencyLi=
censeInfo | grep GNU=E2=80=9D shows several GPL dependancies (may be duplic=
ated?). It may be that these items are dual licensed with a license >that i=
s comparable with the Apache license?
[Kam] This analyzes jars required to build the binary artifacts - so my ass=
umption is that it is not relevant to release just the source?
>I also notice that you have release downloads on your web site. [3] Please=
 make it clear that these are not Apache releases. I assume this is a work =
in progress but you might also want to look at the branding requirements at=
 the same time and fix those as well. [4][Kam] Is this a requirement to rel=
ease? We were planning on adding branding (as well as your suggestion above=
) once we release 0.8.1. (The branding issues was noted by John a few weeks=
 ago). If this is a blocking issue we can update the site now. Note - the g=
earpump site is under=C2=A0https://github.com/apache/incubator-gearpump-sit=
e=C2=A0and is not bundled with the 0.8.1 source release.
>- there a few files with incorrect Apache headers [2] (also brought up las=
t RC)[Kam] I will add the full header to =C2=A0worker.js and rerun rat.
>LICENSE is still missing, in general anything that is bundled needs to be =
added to LICENSE. [1]
>- pygments CSS[Kam] Are you referring to=C2=A0./docs/css/pygments-default.=
css? This isn't embedding any pygments source code - just defaults for the =
gearpump site.
>- normalize (in bootstrap)[Kam] I missed this (as you also mention in your=
 vimeo video) and will add a licenses/LICENSE-normalize.txt and related hea=
der in LICENSE
>- polypill (in moderniser)
[Kam] I will add a licenses/LICENSE-polyfill.txt and related header in LICE=
NSE
>Also What happen to the binary files that were in the the last RC? Has the=
 creative commons licensing issue been resolved?
Based on just releasing source there are no CCL related artifacts included =
in the .tgz.
ThanksKam=20

    On Monday, July 25, 2016 9:59 PM, Justin Mclean <justin@classsoftware.c=
om> wrote:
=20

 Hi,

Looks much better than the last release candidate, however still +0 (bindin=
g) due to LICENSE issues, the items brought up for the last RC have not bee=
n addressed and possible GPL dependancies.

All like like there may be license dependancy issues, but I=E2=80=99m not f=
amiliar enough with sbt and the project to comment. This "sbt dependencyLic=
enseInfo | grep GNU=E2=80=9D shows several GPL dependancies (may be duplica=
ted?). It may be that these items are dual licensed with a license that is =
comparable with the Apache license?

I also notice that you have release downloads on your web site. [3] Please =
make it clear that these are not Apache releases. I assume this is a work i=
n progress but you might also want to look at the branding requirements at =
the same time and fix those as well. [4]

I checked:
- incubating in release name
- signatures and hashes good
- LICENSE is better, but still missing bundled items brought up last RC
- there a few files with incorrect Apache headers [2] (also brought up last=
 RC)
- can compile from source

LICENSE is still missing, in general anything that is bundled needs to be a=
dded to LICENSE. [1]
- pygments CSS
- normalize (in bootstrap)
- polypill (in moderniser)

One issue here is that you=E2=80=99re not following the terms of the bundle=
d licenses (also brought up last RC) Just mentioning the license in LICENSE=
 is not enough, the full text of the license needs to be included somewhere=
, usually this is in the header, but if it=E2=80=99s not there you need to =
include it. I see you have added some files to the licenses directory but h=
aving "Copyright (c) <year> <copyright holders>=E2=80=9D in them doesn=E2=
=80=99t really tell the whole story does it :-)

Also What happen to the binary files that were in the the last RC? Has the =
creative commons licensing issue been resolved?

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#guiding-principle
2. gearpump-0.8.1-RC4-incubating/services/dashboard/views/cluster/workers/w=
orker/worker.js
3. http://gearpump.apache.org/downloads.html
4. http://incubator.apache.org/guides/branding.html
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


------=_Part_5991943_356000626.1469552923882--