incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Apache SystemML 0.10.0-incubating (RC1)
Date Wed, 01 Jun 2016 01:18:48 GMT
Hi,

Sorry -1 (binding) due to unexpected binaries in the source release.

For the source artefact I checked:
- signatures and hashes good
- file name contain incubating
- DISCLAIMER exists
- LICENSE and NOTICE correct
- There are unexpended binary in the source release (see below)
- All files have apache headers
- Can compile from source

There’s a number of binary files included in the source release:
ls ./src/test/config/hadoop_bin_windows/bin
hadoop.dll	hadoop.lib	libwinutils.lib	winutils.pdb
hadoop.exp	hadoop.pdb	winutils.exe

There a large number of files at [1] so it’s not entirely clear what the release artefacts
are to vote on you might want to just include the .zip / .tar.gz files next time.

I also looked at the binary release, nice to see entirely different LICENSE there based on
the contents of the file. Minor issue there’s no need to list the copyright for abego software
or ANTLR software in the NOTICE file as both are BSD licensed. [2] Please fix this for the
next release.

Thanks,
Justin


1. https://dist.apache.org/repos/dist/dev/incubator/systemml/0.10.0-incubating-rc1/
2. http://www.apache.org/dev/licensing-howto.html#permissive-deps
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message