incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josh Elser <els...@apache.org>
Subject Re: [VOTE] Apache Slider (incubating) release 0.91.0-incubating
Date Wed, 22 Jun 2016 15:57:18 GMT
Thanks for taking a close look as always, Justin!

I didn't think that one through -- "it's just used for testing, the .war 
is fine". I appreciate you catching it. I'll try to find a way to build 
that on the fly for the tests to use instead leaving it static in the 
source-release.

Justin Mclean wrote:
> Hi,
>
> Sorry but it -1 binding due to a war file in the source release [1] The war file contains
compiled jar files.
>
> Everything else is fine and if that file wasn’t there I would vote +1.
>
> I checked:
> - name includes incubating
> - signatures and hashes good
> - DISCLAIMER exists
> - LICENSE and NOTICE good
> - unexpected binary in source release [1]
> - all ASF licensed source files have Apache headers
> - can compile from source
>
> Thanks,
> Justin
>
> 1. apache-slider-0.91.0-incubating/app-packages/tomcat/src/test/resources/slider-test.war
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message