incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache Fineract 0.1.2 (incubating)
Date Fri, 20 May 2016 01:48:52 GMT
Hi,

-1 (binding) until GPL issues / dependancy clarified.

My understand is that Hibernate is an optional dependancy here and that it is only use to
run some tests and it is not required to use the product? Can you confirm that please. 

As is not bundled then there's no need to mention it at all in LICENSE or NOTICE or include
the GPL license [1] and doing so just causes confusion.

I checked:
- files include “incubating”
- signature good and md5 hash checks out
- DISCLAIMER exists
- LICENSE is missing a couple of licenses
- NOTICE contain extra text that I’m not sure why it’s included
- Some source files (e.g. SQL and shell scripts) are missing Apache headers
- One unexpected archive in source release [3] but contents are ok.
- didn’t try to compile

LICENSE issues is missing MIT//BSD licensed polyfill bundled in [2]

If something is dual licensed (i.e. uglify) then you only need to select one license. This
is even more important if it’s MIT or GPL licensed (i.e. html5shiv or jszip). There should
be no need to include the text of the GPL license and t’s probably a risk to do so.

You may want to consider signing the release with an apache email address.

The is an archive included in the source release is this required? [3]

Thanks,
Justin

1. ./licenses/hibernate_lgpl.txt
2. ./docs/system-architecture/js/vendor/bootstrap-3.0.0/assets/respond.min.js
3. ./docs/system-architecture/css/toc-0.1.2.zip
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message