incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] MADlib v1.9-rc1
Date Thu, 07 Apr 2016 00:52:16 GMT
Hi,

+1 binding

I checked:
- release name contains incubating
- signatures and hashes good
- DISCLAIMER exists
- LICENSE good
- NOTICE has minor documentation issue
- Apache files have Apache headers. All 16 of them :-) -  there are 711 unknown but assumed
BSD or Apache where trivial.
- No unexpected binary files in source release
- Can compile from source

Minor/trivial issues:
- Be nice if the release was signed by an apache email address rather than a gmail one.
- Given that the code by by EMC Corporation and  The Regents of the University of California
are BSD licensed (and listed in LICENSE) there no need to add those copyrights to NOTICE.
[1]
- You may want to double check copyright/license of [2] as it contains "Copyright (c) 2014
gpadmin” which in not mentioned in LICENSE.
- Looks like the section in the README under "incorporates material from the following third-party
components” needs updating.

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
2. ./src/ports/postgres/modules/pmml/table_to_pmml.sql_in


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message