Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: [VOTE] MADlib v1.9alpha-rc2
From: Justin Mclean <justin@classsoftware.com>
In-Reply-To: 
 <CAKBQfzQh=J3DrFSgFEY8teRDpEf5Yz3r7eBffTZVVN_9evpBJg@mail.gmail.com>
Date: Thu, 10 Mar 2016 10:33:52 +1100
Content-Transfer-Encoding: quoted-printable
Message-Id: <1C6EEDC8-6B71-433D-A70F-1B824C45FBA3@classsoftware.com>
References: 
 <CAKBQfzQh=J3DrFSgFEY8teRDpEf5Yz3r7eBffTZVVN_9evpBJg@mail.gmail.com>
To: general@incubator.apache.org

Hi,

+1 on the assumption that future release will fix up the header =
situation

I checked:
- signatures good
- DISCLAIMER exists
- LICENSE is missing some BSD licensed software
- NOTICE contains too many copyright lines, copyright lines should not =
be in NOTICE unless they are from relocated headers [5]
- Unknown if all files have correct headers or not (700+ files without =
Apache headers) with only 16 files have Apache headers
- No unexpected binary files
- Can compile from source

LICENSE is missing info on:
- BSD licensed software copyright 2011-2012, Florian Schoppmann [2]
- BSD license software copyright 2004, 2015 Sandia Corporation. [3]
- BSD licensed software copyright 2011 Clement Creusot [4]

Given the large number of missing headers it=E2=80=99s extremely =
difficult to review this release, it is impossible to know if an =
individual file without a header is BSD or Apache licensed. Going =
forward to know if a file is missing an Apache header you would need to =
compare it with the previous release which is hardly ideal. Hopefully =
the legal discussion will come to some conclusion / consensus and the =
header situation can be resolved in future releases.

A couple of minor things:
- consider signing with an apache email address
- may want to double check copyright line in this file [1]

Thanks,
Justin

1. ./src/ports/postgres/modules/pmml/table_to_pmml.sql_in
2. ./src/ports/postgres/cmake/FindPostgreSQL.cmake
3. ./cmake/UseLATEX.cmake
4. ./cmake/FindArmadillo.cmake
5. http://www.apache.org/legal/src-headers.html#headers=

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org