incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Witt <joe.w...@gmail.com>
Subject Re: [VOTE] Release apache-singa-incubating-0.2.0
Date Sun, 10 Jan 2016 17:20:41 GMT
John,

The language within the header of those files includes things like the
following as found in ltmain.sh

# As a special exception to the GNU General Public License,
# if you distribute this file as part of a program or library that
# is built using GNU Libtool, you may include this file under the
# same distribution terms that you use for the rest of that program.

I suspect that is the exception being referred to here since they
mentioned their use is consistent with being for build.

Thanks
Joe

On Sun, Jan 10, 2016 at 12:18 PM, John D. Ament <johndament@apache.org> wrote:
> Daniel,
>
> Could you explain those exceptions? I don't think I've ever heard of GPL
> being OK'd to use in an AL release.
>
> John
>
> On Sun, Jan 10, 2016 at 7:41 AM Daniel Gruno <humbedooh@apache.org> wrote:
>
>> +0.999 - seem okay but some files are missing license headers.
>>
>> The seemingly GPL (some aren't GPL at all) files Justin linked to have
>> exceptions for use which allows it.
>>
>> I ran it through my usual stuff,
>> http://compliance.rocks/result.html?358649c0
>> - and every single GPL-licensed file has an exception which allows it to
>> be bundled with ALv2 projects.
>>
>> With regards,
>> Daniel.
>>
>> On 01/10/2016 01:14 PM, Justin Mclean wrote:
>> > Hi,
>> >
>> > Sorry it’s -1 binding due to the inclusion of GPL licenced files [1] and
>> other license issues [2] and unable to compile from source. Happy to
>> reconsider if explained.
>> >
>> > I checked:
>> > - release contains incubating
>> > - signatures and hashes good
>> > - DISCLAIMER exists
>> > - LICENSE has some minor issues
>> > - NOTICE contains too much information
>> > - No binaries in source
>> > - All source files have apache header
>> > - Unable to compile from source
>> >
>> > GPL licensed files includes:
>> > ./config/ltmain.sh
>> > ./config/ltversion.m4
>> > ./config/lt~obsolete.m4
>> > ./config/config.guess
>> > ./config/config.sub
>> > ./config/install-sh (?)
>> > ./Makefile.in (?) this also has a ASF header which seems odd
>> >
>> > While this seems to be a build tool [7] I’m not 100% sure if all files
>> here are OK.
>> >
>> > For LICENSE:
>> > - path to tinydir.h is incorrect
>> > - missing licence for ./include/singa/utils/cuda_utils.h
>> > - include/utils/common.h path is incorrect and the file most likely has
>> an incorrect ASF header
>> > - missing license for (BSD licensed) ./tool/cpplint.py. Possibly
>> tool/cppling.py should be tool/cpplint.py?
>> > - missing licence for (BSD license?) ./examples/rnnlm/create_data.cc
>> > - copyright for tinydir is incorrect should be "Cong Xu, Baudouin
>> Feildel”
>> > - files in include/mshadow/* are missing Apache header so it’s unclear
>> if they are Apache licensed or where they are from. I think this is sort of
>> OK [3]
>> > - copyright "Copyright (c) 2014, 2015, The Regents of the University of
>> California (Regents)” may be incorrect, you may want to double check years
>> >
>> > May be other issues as at this point i gave up.
>> >
>> > Also LICENSE file is also missing some whitespace on the first line
>> which you may want to fix.
>> >
>> > For NOTICE:
>> > - No need to include BSD licence information [4]
>> > - Too much info in NOTICE [5]
>> > - No need to list non bundled software [6]
>> >
>> > Would also be nice to have compile instructions. On OS X configure fails
>> for me with:
>> > configure: error: unable to find cblas_sgemm() function
>> >
>> > Assuming you run configure &&  make to compile and OS X is supported
but
>> it’s not 100% clear.
>> >
>> > Thanks,
>> > Justin
>> >
>> > 1. http://www.apache.org/legal/resolved.html#category-x
>> > 2. http://www.apache.org/dev/licensing-howto.html#permissive-deps
>> > 3. https://github.com/dmlc/mshadow
>> > 4. http://www.apache.org/dev/licensing-howto.html#permissive-deps
>> > 5. http://www.apache.org/dev/licensing-howto.html#mod-notice
>> > 6. http://www.apache.org/dev/licensing-howto.html#guiding-principle
>> > 7. http://www.apache.org/legal/resolved.html#build-tools
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: general-help@incubator.apache.org
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message