incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Dekany <ddek...@freemail.hu>
Subject Re: [VOTE] Release Apache FreeMarker 2.3.24-rc01 (incubating)
Date Fri, 22 Jan 2016 18:51:45 GMT
Friday, January 22, 2016, 9:13:15 AM, Justin Mclean wrote:

> Hi,
>
> +1 binding
>
> There are unexpected jars in source release but this will be fixed in a later release.
[1]
>
> I checked:
> - incubating in release name
> - disclaimer exists
> - license and notice correct
> - unexpected binary files in source release (jars)
> - all source files have Apache headers
> - can compile from source
>
> You may also want to consider signing the artefacts with an apache
> email address rather than the freemail one used.
>
> I'd also suggest that you name each release candidate in order e.g
> rc1, rc2, rc3 etc etc rather than naming them all rc1. There's less
> chance of confusion and people voting on the wrong release candidate that way.

As FreeMarker RC-s are public releases that are advertised on the
front page and so on, if because of some internal iteration we skip
numbers, that's somewhat confusing for the end-user. Not a big deal,
but still. Also note that I only did this inside the poddling mailing
list, not here.

> The GAE release also includes a .settings directory which probably
> shouldn't be included in the release?

Both source releases contain that and .project and .classpath too. It
can be convenient for developers. (Like they do this at JBoss for
plugin projects too.) But yes, it would be cleaner if we export the
relevant Eclipse settings to xml-s, etc.

> Thanks,
> Justin
>
> 1. https://issues.apache.org/jira/browse/FREEMARKER-15
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

-- 
Thanks,
 Daniel Dekany


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message