incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] TinkerPop 3.1.0-incubating Release
Date Sat, 21 Nov 2015 22:58:39 GMT
Hi,

+1 binding

I checked:
- release files include incubating in the name
- signatures and hashes good
- DISCLAIMER exists
- LICENSE good (although no need to list Apache licensed software)
- NOTICE has an issue (see below)
- All source files have Apache headers
- No unexpected binaries in source release
- Don’t compile as it requires later version of java than I have installed.

Bundled with the software (according to the license file)  is Activiti which is Apache licensed
and has a notice file [1] (although most of this content shouldn't actually be in license).
As per [2] this needs to be looked at and parts added to the Tinkerpop NOTICE file.  However
I can’t even find the two files mentioned in LICENSE so it may be that nothing needs to
be done and those lines removed from LICENSE?

As noted in the previous incubator release [3] can the binary NOTICE/LICENSE files please
be fixed before the next release. Your mentors should be able to help with this.

Thanks,
Justin

1. https://github.com/Activiti/Activiti/blob/master/distro/src/notice.txt
2. http://www.apache.org/dev/licensing-howto.html#alv2-dep
3. https://mail-archives.apache.org/mod_mbox/incubator-general/201507.mbox/%3C2B93B23F-63F9-4BF0-9079-AA63FF68813D@classsoftware.com%3E


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message