incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephen Mallette <spmalle...@gmail.com>
Subject Re: [VOTE] TinkerPop 3.1.0-incubating Release
Date Sun, 22 Nov 2015 06:25:21 GMT
> Bundled with the software (according to the license file)  is Activiti
which is Apache licensed and has a notice file [1] (although most of this
content shouldn't actually be in license). As per [2] this needs to be
looked at and parts added to the Tinkerpop NOTICE file.  However I can’t
even find the two files mentioned in LICENSE so it may be that nothing
needs to be done and those lines removed from LICENSE?

Maybe we did something wrong here, but those classes are here:

https://github.com/apache/incubator-tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriterHelper.java

The are basically just recreated as inner classes in that java file.  Is
that the wrong way to do that? or is that ok, but we've got to deal with
LICENSE/NOTICE differently for them?

> As noted in the previous incubator release [3] can the binary
NOTICE/LICENSE files please be fixed before the next release. Your mentors
should be able to help with this

The link you posted was for 3.0.0-incubating, but our most recent release
was 3.0.2-incubating, a release where i was glad to hear that you were
happy with the changes to our binary LICENSE/NOTICE:

https://mail-archives.apache.org/mod_mbox/incubator-general/201510.mbox/%3C03DC59B6-FF46-4229-AFB0-5DF42D968DF5@me.com%3E

I something amiss in our current version that you still see wrong somehow?

Thanks,

Stephen


On Sat, Nov 21, 2015 at 5:58 PM, Justin Mclean <justin@classsoftware.com>
wrote:

> Hi,
>
> +1 binding
>
> I checked:
> - release files include incubating in the name
> - signatures and hashes good
> - DISCLAIMER exists
> - LICENSE good (although no need to list Apache licensed software)
> - NOTICE has an issue (see below)
> - All source files have Apache headers
> - No unexpected binaries in source release
> - Don’t compile as it requires later version of java than I have installed.
>
> Bundled with the software (according to the license file)  is Activiti
> which is Apache licensed and has a notice file [1] (although most of this
> content shouldn't actually be in license). As per [2] this needs to be
> looked at and parts added to the Tinkerpop NOTICE file.  However I can’t
> even find the two files mentioned in LICENSE so it may be that nothing
> needs to be done and those lines removed from LICENSE?
>
> As noted in the previous incubator release [3] can the binary
> NOTICE/LICENSE files please be fixed before the next release. Your mentors
> should be able to help with this.
>
> Thanks,
> Justin
>
> 1. https://github.com/Activiti/Activiti/blob/master/distro/src/notice.txt
> 2. http://www.apache.org/dev/licensing-howto.html#alv2-dep
> 3.
> https://mail-archives.apache.org/mod_mbox/incubator-general/201507.mbox/%3C2B93B23F-63F9-4BF0-9079-AA63FF68813D@classsoftware.com%3E
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message