Return-Path: X-Original-To: apmail-incubator-general-archive@www.apache.org Delivered-To: apmail-incubator-general-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 02DDA17EFC for ; Fri, 25 Sep 2015 19:13:17 +0000 (UTC) Received: (qmail 66967 invoked by uid 500); 25 Sep 2015 19:13:16 -0000 Delivered-To: apmail-incubator-general-archive@incubator.apache.org Received: (qmail 66745 invoked by uid 500); 25 Sep 2015 19:13:16 -0000 Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@incubator.apache.org Delivered-To: mailing list general@incubator.apache.org Received: (qmail 66733 invoked by uid 99); 25 Sep 2015 19:13:16 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Sep 2015 19:13:16 +0000 Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id E1EB31A0056 for ; Fri, 25 Sep 2015 19:13:15 +0000 (UTC) Received: by wicge5 with SMTP id ge5so33526018wic.0 for ; Fri, 25 Sep 2015 12:13:14 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.105.196 with SMTP id go4mr4928092wib.36.1443208394700; Fri, 25 Sep 2015 12:13:14 -0700 (PDT) Received: by 10.194.59.1 with HTTP; Fri, 25 Sep 2015 12:13:14 -0700 (PDT) In-Reply-To: <1FA3A4B2-DD73-49F7-AF08-A545813ECCB5@me.com> References: <1FA3A4B2-DD73-49F7-AF08-A545813ECCB5@me.com> Date: Fri, 25 Sep 2015 12:13:14 -0700 Message-ID: Subject: Re: [VOTE] Release Apache htrace-4.0.1-incubating From: "Colin P. McCabe" To: general@incubator.apache.org Content-Type: text/plain; charset=UTF-8 On Fri, Sep 25, 2015 at 8:15 AM, Justin Mclean wrote: > Hi, > > +1 binding. You may want consider some changes to LICENSE / NOTICE for the next release. Thanks, Justin. > > I checked: > - file contain incubating > - DISCLAIMER exists > - LICENSE and NOTICE have minor issues (see below) > - all source files have headers > - no unexpected binary files > - can compile source release > > For LICENSE: > - Missing MIT licence normalize.css Hmm. This is part of bootstrap, so it should be covered by the section on that? > - Not obvious that Units, CMP or go-codec is contained in the source release. If so they are not required to be mentioned in LICENSE. CMP is contained in htrace-c/src/util/cmp.c and htrace-c/src/util/cmp.h. I filed HTRACE-268 for adding a comment about where the CMP files live... and for removing Units and go-codec from LICENSE, since they are not bundled in the repo. > > It's best to try a keep content of NOTICE to a minimum. [1] > - No need for NOTICE to contain reference to license (everything is permissive) > - The Owl logo information should be in LICENSE I think I filed HTRACE-267 for moving the owl logo license information out of INFO, and into LICENSE. cheers, Colin > > Thanks, > Justin > > 1.http://www.apache.org/dev/licensing-howto.html#mod-notice > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org > For additional commands, e-mail: general-help@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org For additional commands, e-mail: general-help@incubator.apache.org