incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache AsterixDB Hyracks 0.2.16-incubating (RC3)
Date Sun, 20 Sep 2015 00:03:22 GMT
Hi,

+1 (binding)

I checked:
- has incubating in release name
- signatures and hashes correct
- DISCLAIMER exists
- LICENSE has minor issues / missing a couple of MIT licenses (see below)
- NOTICE correct
- No binary files in source release
- All source files have headers (although there are some test data files which don’t)
- Can compile from source

The License is OK , but I think it would be better to mention the original software (and version)
rather than the source they were copied from as per [1].

For instance from reading the license It’s not immediate obvious that jQuery or  jQuery-ui
is bundled. Files in question are all MIT licensed (or dual licensed) and include:
./hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/javascript/flot/jquery.flot.min.js
./hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/javascript/jquery/plugins/jquery-ui.min.js
./hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/javascript/jquery/plugins/jquery.getParams.js
./hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/javascript/jquery/plugins/jquery.timer.js
./hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/stylesheet/jquery-ui/themes/base/jquery-ui.css
./hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/javascript/jsplumb/jquery.jsPlumb-1.3.5-all-min.js

LICENSE is missing [1] ( also [2]) details for jQuery.getParams and jquery.timer.js.

And sections for these files (text from Sherlock Homes):
./hyracks/hyracks-examples/text-example/textserver/data/file1.txt
./hyracks/hyracks-examples/text-example/textserver/data/file2.txt

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
2. http://www.apache.org/dev/licensing-howto.html#guiding-principle
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message