incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Nalley <da...@gnsa.us>
Subject Re: Podling request: Gerrit
Date Tue, 14 Jul 2015 13:31:01 GMT
On Tue, Jul 14, 2015 at 1:14 AM, Ian Maxon <imaxon@uci.edu> wrote:
>> This is pretty far from what the norm is, and is being proposed by a
>> podling, so I'd expect some skepticism. Other podlings, have proposed
>> similar workflows (albeit with extra problems.) and were not allowed
>> to retain that procedure.
>
> I think there's some confusion here about what the workflow exactly is
> at the moment. ASF git is the source of truth here, and nothing goes
> into it without a committer putting it there by hand.

That's good.

> We use Gerrit as
> a tool to do code reviews and to organize the commits, as well as to
> facilitate easy testing. However that's all it's used for- we still
> clone from repositories that come downstream from ASF, not the other
> way around. I'd be interested to understand how this would be
> considered any different than what is done with Github Pull Requests.
>

So GH PR have a subtle distinction (at least in the way that they are
handled at the ASF). Projects can't merge pull requests into the repo
at github. Non-committers see a workflow that is the Github workflow,
because that's very familiar, and lowers the barrier to contribution.
Committers, however, have a very different workflow than the folks who
typically review and close pull requests on github. They have to take
the patch [1], and merge it into the canonical repository at the ASF,
which then appears in the github repository because of the mirror
process.  This stops the problem of diverging codebases that you are
currently experiencing, calls to rewrite history to align the ASF repo
with the external repo, etc.

There are some other problems, that aren't necessarily as worrisome,
but should be something to consider. First, you're relying on a third
party to provide that resource. That's not inherently a problem, but
we have a number of examples of projects using external tools and
those being shut down or phased out which causes tremendous disruption
to projects. It's also at the old project's home, which might cause
some folks to question whether the project is truly independent, or
not.

--David

[1] https://patch-diff.githubusercontent.com/raw/apache/airavata/pull/18.patch

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message