incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Boudnik <...@apache.org>
Subject Re: [DISCUSSION] Graduate Ignite from the Apache Incubator
Date Thu, 23 Jul 2015 01:08:43 GMT
On Wed, Jul 22, 2015 at 04:46PM, Ted Dunning wrote:
> Actually, that document just makes me more dubious.
> 
> The problems I see are:
> 
> 1) the identity of the original person doing the work is obscured by the
> squash commits

No. Besides, I am not talking about rebases and force-pushes. I am talking
about branching models in the local environment.

> 2) the deletion of the bug branch after integration involves deletion of
> important information from git (and I thought that rewriting of history is
> outlawed on the apache git repo in any case)

No and no. Removing a merged branch doesn't remove a thing, but a reference
(called 'branch' in git)

> 3) the mention of deleting branches makes me worry that development is
> going on using a separate repos that aren't visible to the apache repo

And no again. See above. Besides, I fail to find how branching practices are
relevant to the discussion at hands? E.g why IPMC (or the foundation) would
put itself in the seat of the development practices' adviser? How can a
branching model or commit practices be decided by anyone but the community
developing the project?

Cos

> I still see the problem of understanding what happened.  I just reviewed a
> dozen or so of the most recent JIRA's and found only the slightest
> discussion in the comments on any of them (1 had a round or two, another
> had a little less and all the rest had none at all).
> 
> Here[1,2,3] are searches for discussions on a sample JIRA.
> 
> I find it hard to believe that these bugs are being resolved clairvoyantly
> and have to conclude that there is considerable discussion of these issues
> going on somewhere other than JIRA or the mailing list.
> 
> [1]
> https://www.google.com/webhp?q=site:http:%2F%2Fmail-archives.apache.org%2Fmod_mbox%2Fincubator-ignite-dev%2F201507.mbox+IGNITE-1095
> 
> [2]
> https://www.google.com/webhp?q=site:http:%2F%2Fmail-archives.apache.org%2Fmod_mbox%2Fincubator-ignite-dev%2F201507.mbox+IGNITE-1095#q=site:http:%2F%2Fmail-archives.apache.org%2Fmod_mbox%2Fincubator-ignite-dev%2F201507.mbox+IGNITE-1031
> 
> [3]
> https://www.google.com/webhp?q=site:http:%2F%2Fmail-archives.apache.org%2Fmod_mbox%2Fincubator-ignite-dev%2F201507.mbox+IGNITE-1095#q=site:http:%2F%2Fmail-archives.apache.org%2Fmod_mbox%2Fincubator-ignite-dev%2F201507.mbox+IGNITE-1100
> 
> On Wed, Jul 22, 2015 at 4:16 PM, Konstantin Boudnik <cos@apache.org> wrote:
> 
> > After a quick walk through the master log I see that a bunch of the
> > questionable commits are resulted from the dev. branches histories not
> > being
> > properly squashed before the feature is merged into the master.
> >
> > This is something that mentors have asked to address before and, in fact,
> > the
> > community is making changes as we speak
> >     https://cwiki.apache.org/confluence/display/IGNITE/Sprint+Process
> >
> > specifically under 'git workflow'. Arguably, squashing is a matter of taste
> > and I would refrain from pushing the community one way or another,
> > although I
> > surely don't like non-squashed histories like that.
> >
> > Development process is actually documented on the wiki and is followed by
> > the
> > community. I don't see why it is looks closed or off-list, really. Any new
> > contributor can start picking up things using these tools. In fact, they
> > do -
> > the community has new committers and active users that have no problems
> > figuring out how to contribute into the project (according to the dev@ and
> > user@ lists). Does it answer your concerns, Ted?
> >
> > Regards,
> >   Cos
> >
> > On Wed, Jul 22, 2015 at 11:07PM, Daniel Gruno wrote:
> > > On 07/22/2015 09:23 PM, Julian Hyde wrote:
> > > > I reviewed Ignite’s commit log and email lists. I got the impression
> > of a
> > > > split personality: The dev list[1] is very open and clearly following
> > the
> > > > Apache Way. Meanwhile, the commit log[2] is (to my eyes at least)
> > > > difficult to decipher.
> > > >
> > > > In the commit log, messages such as "Merge remote-tracking branch
> > > > 'origin/master’” and "# master minor”, "GG-10559 - Improvements.”
are
> > > > typical. Very few descriptive comments or references to IGNITE-xxx
> > cases
> > > > that could provide further explanation. Those are indications to me
> > that
> > > > development is been driven by off-list meetings.
> > > >
> > > > If the Ignite committers want to build a diverse community of
> > developers,
> > > > I think they need to make their commits more transparent to match the
> > > > excellent transparency they have achieved on their mailing list.
> > > >
> > > > Julian
> > > >
> > > > [1]
> > http://mail-archives.apache.org/mod_mbox/incubator-ignite-dev/201507.mbox/browser
> > > > [2] https://github.com/apache/incubator-ignite/commits/master
> > > >
> > > >
> > >
> > > The GG-10559 commit log (along with the 'oops' email sent to dev by
> > > mistake today) seems to indicate (this is just speculation, I would love
> > > for someone to answer whether this is the case) that commits are being
> > > based off an internal JIRA instance (or other bug tracking system) not
> > > hosted at the ASF.
> > >
> > > Furthermore, I have found that there are 207 JIRA tickets with NO
> > > description, discussion or useful information other than ownership
> > > changing hands and then suddenly the tickets have been resolved with no
> > > explanation, suggesting that either people have not been properly taught
> > > about how to share information and collaborate as a community, or the
> > > actual discussions and 'ping-pong' happen elsewhere, outside our view.
> > >
> > > I naturally hope there is no reason for concern, and I would love to get
> > > some insight into why these things pop into view when you examine the
> > > development process.
> > >
> > > With regards,
> > > Daniel.
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message