incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Sentry incubating version 1.5.0 (rc0)
Date Fri, 05 Jun 2015 04:27:35 GMT
Hi,

-1 binding due to license issues (and involves GPL) and release is in wrong location.

I checked:
-  incubating in artefact name
- signatures and hashes correct
- DISCLAIMER exists
- LICENSE is not correct (see below)
- NOTICE is correct
- no unexpected binaries in source release
- Most files have apache headers (see below)

There are several non Apache licensed bits that need to be aded to LICENSE or not included
in the release:
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/velocity/jquery.autocomplete.js
(dual MIT/GPL)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_ar.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_bg.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_da.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_de.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_es.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_fa.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_fi.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_fr.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_hi.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_hu.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_it.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_nl.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_no.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_pt.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_ro.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_ru.txt
(BSD licensed)
./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_sv.txt
(BSD licensed)

Please place the release in the correct place [1], note that this is a “MUST” and was
noted as an issue for the last incubating candidate.

For the next release also consider:
- The are several .vm and .sql files that are missing apache headers
- Consider removing the multiple .gitignore files in the source release

Thanks,
Justin

1. http://incubator.apache.org/incubation/Incubation_Policy.html#Releases
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message