Return-Path: X-Original-To: apmail-incubator-general-archive@www.apache.org Delivered-To: apmail-incubator-general-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5C7DA17332 for ; Mon, 30 Mar 2015 22:32:49 +0000 (UTC) Received: (qmail 62659 invoked by uid 500); 30 Mar 2015 22:32:48 -0000 Delivered-To: apmail-incubator-general-archive@incubator.apache.org Received: (qmail 62462 invoked by uid 500); 30 Mar 2015 22:32:48 -0000 Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@incubator.apache.org Delivered-To: mailing list general@incubator.apache.org Received: (qmail 62450 invoked by uid 99); 30 Mar 2015 22:32:48 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Mar 2015 22:32:48 +0000 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE X-Spam-Check-By: apache.org Received-SPF: error (nike.apache.org: local policy) Received: from [96.114.154.160] (HELO resqmta-po-01v.sys.comcast.net) (96.114.154.160) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Mar 2015 22:32:20 +0000 Received: from resomta-po-17v.sys.comcast.net ([96.114.154.241]) by resqmta-po-01v.sys.comcast.net with comcast id 9yWF1q0095Clt1L01yWyNB; Mon, 30 Mar 2015 22:30:58 +0000 Received: from tinybb.boudnik.org ([24.130.135.131]) by resomta-po-17v.sys.comcast.net with comcast id 9yWx1q00N2qGB6001yWyTx; Mon, 30 Mar 2015 22:30:58 +0000 Received: by tinybb.boudnik.org (Postfix, from userid 1002) id 076751F7; Mon, 30 Mar 2015 22:31:09 +0000 (UTC) Date: Mon, 30 Mar 2015 22:31:09 +0000 From: Konstantin Boudnik To: general@incubator.apache.org Subject: Re: "junior" Mentor request advice from "senior" Mentor. Message-ID: <20150330223109.GR1657@boudnik.org> References: <5517DDAA.6090004@apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5517DDAA.6090004@apache.org> X-Organization: It's something of 'Cos User-Agent: Mutt/1.5.21 (2010-09-15) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1427754658; bh=jJXLllqwI9Sbkl5Xvo7X90zNK9ngCntzXBCsa2j1i/g=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=vfkuXkPkPY0xW8PmtWopBarlBrxLMNSpFE8jMKMIKivF0x33qoSMNYLmFWcFca4pg L/6yccBEYiSxjtvggAyORnWvpBOQrCOqJulwUTnVPQEbRV1c6RjBRCCZau2XsZlEpQ hbon0jPqMakaTYBpqljP4uBVX2VEGNTsINwgLCJz1teH4Lb8vk4c7H4/mXH1B2zRDK AKQgPIZlJquqHz3N7mLWrkjmWGGL9zHZc0M3s0IghR4KguwCZg/pRon04WKpboEWiY NFFWd1UdNhQfx3qerrCwmhb8JpYV9750HATbDXvIA3Q4sv1lLLVVee+ml6Vuh13xXp nbAszPVGcAJ/g== X-Virus-Checked: Checked by ClamAV on apache.org On Sun, Mar 29, 2015 at 01:10PM, Branko Čibej wrote: > On 22.03.2015 09:05, jan i wrote: > > Hi. > > > > Sorry could not resist the subject line, but fact is I need a good advice. > > I know our rulebook about including 3rd party libraries, but rules are open > > to interpretation, and since I am involved in the development I consider my > > opinion for biased. > > > > In Corinthia we depend on the following third party libraries (currently > > not in repo): > > zlib1 > > libxml2 > > iconv > > SDL > > SDL_Image. > > > > The first 3 ones are not available precompiled for windows 64bit (at least > > not from a trustworthy source), so we need to make it available. > > > > I see 3 options: > > 1) Ask developers to download and build by them self (sadly enough they > > also need to setup the vcxproj file) > > 2) one PPMC (in this case me) precompilles all libs, make them available as > > a zip on minotaur, > > which of course is a trusted source, but somewhat ackward to the project. > > 3) the sources are added to the repo, in a designated directory and > > integrated in our build system. > > > > I would prefer to suggest 3), but I want to be absolutely sure, that we do > > it the right way. > > I would suggest: > > a) put a README, for each downloaded lib, with the original URL and version > > b) add the licenses to the LICENSE file > > c) copy the README into NOTICES > > d) In the first commit, make a commit text like the README. > > e) Make the missing bits for a 64bit version, and integrate in our build > > system. > > > > Would that be a good solution to the problem, or do you have other ideas or > > corrections ? > > > > My goal here is, to make the right decision up front, and not when we have > > cut a release. > > Write a script that downloads the supported versions and include the > necessary vcxproj files in your source distribution. I believe msbuild > can download stuff, so you may even be able to automate the download > from the project file. Not sure what are the licenses of the libs in question, so please refer to http://www.apache.org/legal/resolved.html if in doubt. And Brane's suggestion would work in any case, even with (L)GPL bits. Hosting it outside and letting developers/users to pull them in on their own is pretty much bullet-proof. Cos --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org For additional commands, e-mail: general-help@incubator.apache.org