incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Loughran <ste...@hortonworks.com>
Subject Re: [VOTE] Release Apache Slider 0.61.0-incubating
Date Mon, 09 Feb 2015 13:31:17 GMT



On 8 February 2015 at 22:57:05, Justin Mclean (justinmclean@me.com<mailto:justinmclean@me.com>)
wrote:

Hi,

Sorry but it's -1 binding from me. Willing to change my vote if other incubator members think
these issues are OK for this release and/or corrective action is taken for the next release.


You know, in theory the voting ended a few hours earlier —but what you've said matters so
I want to address it.

This release, 0.61.0, is just a repacking of the source of 0.60.0, with changes to the build
files to get that binary release out. We actually cancelled our first dev@ vote after Billie
felt the transitive dependency license stuff of all the JARs we stuck in weren't validated;
SLIDER-766 addressed that. So it's unfortunate that some of the .py stuff we're using for
templating and testing are cause problems.


As soon as this maintenance release is over, we're going to cut the 0.70-incubating release,
which has all the features and fixes done on the source since the 0.60.0-incubating release.

Would it be OK if we addressed all of the issues in that release? You've identified them,
which will make checking them easy. And as we plan to get that out by the end of the month,
it won't be long before the "latest" release is considered all lined up.


All source files have headers and there no unexpected binaries but looks to be be a few license
and notice issues:

First off I think this needs to be double checked:
./slider-agent/src/main/python/kazoo/tests/util.py

The first line says it's Apache licensed, but the header says it ZPL licensed, which looks
like BSD so should be included in LICENSE.



This looks like the key thing we have to resolve other than just by cutting the files. We
can see what others have done with this bit of source and update the LICENSE file as appropriate.


The product looks to be bundling Apache Accumulo but is missing information from it's NOTICE
file:
See /app-packages/accumulo/NOTICE.txt (or perhaps https://github.com/apache/accumulo/blob/master/NOTICE
?)



We're not actually bundling accumulo, it's just in the source for anyone to build a deployable
package of that or HBase. Accordingly, I don't think this is an issue.


LICENSE also missing BSD licence for RealWorldish Benchmark
vi ./slider-agent/src/main/python/jinja2/examples/rwbench/rwbench.py


we can rm -rf the examples


I also notice that this file ./slider-agent/src/main/python/jinja2/docs/_templates/layout.html
contains "Copyright 2010 by the Pocoo Team". Should that also be in LICENSE?


again, these could be culled

There are also several "Copyright 2008 by I don't know who." in .html files is that a concern?
./slider-agent/src/main/python/jinja2/examples/rwbench/django/layout.html
./slider-agent/src/main/python/jinja2/examples/rwbench/genshi/layout.html
./slider-agent/src/main/python/jinja2/examples/rwbench/jinja/layout.html
./slider-agent/src/main/python/jinja2/examples/rwbench/mako/layout.html

all removable.

The year in NOTICE is also incorrect.


Yeah —saw that crop up with the Twill release, which was allowed through. Already fixed
in our develop branch.
https://github.com/apache/incubator-slider/blob/develop/NOTICE




Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message