incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Amareshwari Sriramdasu <amareshw...@apache.org>
Subject Re: [VOTE] Release Apache Lens 2.0.1-beta-incubating
Date Sat, 28 Feb 2015 04:00:29 GMT
Thanks Justin for your time. Can you please run 'mvn clean package' as
suggested by Srikanth.

Responding to the other issues reported inline here. Let us know if we have
to roll another candidate with those issues fixed or taking care of them in
next release version is sufficient.

On Sat, Feb 28, 2015 at 8:41 AM, Srikanth Sundarrajan <sriksun@hotmail.com>
wrote:

> Hi Justin,
>    I am assuming you are attempting to compile with "mvn compile".  I am
> guessing the build is failing since the server module is depending on
> test-jars meant to be built in lens-server-api module during test-compile,
> and the same isn't available. Can you please try with "mvn clean compile
> test-compile" or "mvn package" or anything that includes the test-compile
> phase.
>
> Regards
> Srikanth Sundarrajan
>
> > Subject: Re: [VOTE] Release Apache Lens 2.0.1-beta-incubating
> > From: justin@classsoftware.com
> > Date: Sat, 28 Feb 2015 11:33:35 +1100
> > To: general@incubator.apache.org
> >
> > Hi,
> >
> > +0 for now (due to compilation issues). If resolved would vote +1
> >
> > For the source release:
> > - signatures and hashes correct
> > - disclaimer exists
> > - incubating in release name
> > - LICENSE good
> > - NOTICE has minor issue (see below)
> > - No unexpected binary files (but did notice two power point files -
> perhaps a more OS format could be used? As these are simple images why not
> just png?)
>
The source for png files started is in pptx. So, pptx files are checked in
source to update images.

> - All source code has headers
> > - Can't compile from source
> >
> > Minor issues
> > - No need to mention any of the JS libraries in NOTICE as they are MIT
> licensed [1]
>
Sure. Will remove.


> > - It may be the that two power point files have embedded fonts as they
> contain "Copyright 2007 Apple Inc., all rights reserved"?
>
Will check if we can remove the copyright or remove the pptx fully.

> >
> > Currently I'm unable to get the source package to compile (on OSX using
> Java 1.7).
> >
> > [INFO]
> ------------------------------------------------------------------------
> > [INFO] Reactor Summary:
> > [INFO]
> > [INFO] Lens Checkstyle Rules ............................. SUCCESS [
> 0.862 s]
> > [INFO] Lens .............................................. SUCCESS [
> 0.029 s]
> > [INFO] Lens API .......................................... SUCCESS [
> 0.518 s]
> > [INFO] Lens API for server and extensions ................ SUCCESS [
> 1.246 s]
> > [INFO] Lens Cube ......................................... SUCCESS [
> 0.236 s]
> > [INFO] Lens DB storage ................................... SUCCESS [
> 0.140 s]
> > [INFO] Lens Query Library ................................ SUCCESS [
> 0.127 s]
> > [INFO] Lens Hive Driver .................................. SUCCESS [
> 0.657 s]
> > [INFO] Lens Driver for JDBC .............................. SUCCESS [
> 0.157 s]
> > [INFO] Lens Server ....................................... FAILURE [
> 11.472 s]
> > [INFO] Lens client ....................................... SKIPPED
> > [INFO] Lens CLI .......................................... SKIPPED
> > [INFO] Lens Examples ..................................... SKIPPED
> > [INFO] Lens Distribution ................................. SKIPPED
> > [INFO] Lens ML Lib ....................................... SKIPPED
> > [INFO] Lens Regression ................................... SKIPPED
> > [INFO]
> ------------------------------------------------------------------------
> > [INFO] BUILD FAILURE
> > [INFO]
> ------------------------------------------------------------------------
> > [INFO] Total time: 16.060 s
> > [INFO] Finished at: 2015-02-28T10:48:24+10:00
> > [INFO] Final Memory: 24M/58M
> > [INFO]
> ------------------------------------------------------------------------
> > [ERROR] Failed to execute goal on project lens-server: Could not resolve
> dependencies for project
> org.apache.lens:lens-server:war:2.0.1-beta-incubating: Could not find
> artifact org.apache.lens:lens-driver-hive:jar:tests:2.0.1-beta-incubating
> in inmobi.repo (https://github.com/InMobi/mvn-repo/raw/master/releases)
> -> [Help 1]
> >
> > Why does it appear that the Apache lens artefacts are publicly deployed
> here [2], are these pre Apache incubator versions of the software?
>
Yes. Some of them are pre-apache releases and some of them are from 1.x
line after incubating apache to support 1.x. Let us know if there are
issues with putting artifacts there.

>
> > For the binary distribution (again all minor issues).
> > -  I'm concerned by the inclusion of  LICENSE-GPLv3 and LICENSE-LGPL
> file. I assume these are there because of dual licensing. They should
> probably be removed.
>
Yes. They are because of dual licensing. They were put as discussed in
legal-discuss threads here :
http://mail-archives.apache.org/mod_mbox/www-legal-discuss/201501.mbox/%3CCAAS6%3D7jJoJMkzMRpSdJ6kAVSZCvSfC5aRD0eMyGzP_rzWyE73Q%40mail.gmail.com%3E
and
http://mail-archives.apache.org/mod_mbox/www-legal-discuss/201502.mbox/%3CCAAS6%3D7gzsAYZMT5mar_nfy9egXB1t3HendDQRMUpkA6dqvhr7w%40mail.gmail.com%3E

Let us know if we should remove them.

> - NOTICE contain several items that shouldn't be there (anything MIT
> licensed for instance)
>
Except the js files, everything else is CDDL+GPL or EPL+EDL, which required
mention in the NOTICE. Will remove mention of js files.

> - NOTICE may be missing required notice from included NOTICE file (I
> didn't check in detail, but would be surprised if it was empty with all
> those jars)
>
Sorry, I did not understand which NOTICE file you are referring to here.
All lens jars have NOTICE in their META-INF. For other jars bundled, the
top level NOTICE is updated with weblink where they can be obtained from.

> - LICENSE is missing licences for opalliance-1.0.jar and xz-1.0.jar
> (public domain). Unless stated the assumption would be that they are Apache
> licensed/copyright Apache.
>
Sure. Will update this.

>
> > Thanks,
> > Justin
> >
> > 1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
> > 2.
> https://github.com/InMobi/mvn-repo/tree/master/releases/org/apache/lens
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
>
>

Thanks
Amareshwari

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message