incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache Lens 2.0.1-beta-incubating
Date Sat, 28 Feb 2015 00:33:35 GMT
Hi,

+0 for now (due to compilation issues). If resolved would vote +1

For the source release:
- signatures and hashes correct
- disclaimer exists
- incubating in release name
- LICENSE good
- NOTICE has minor issue (see below)
- No unexpected binary files (but did notice two power point files - perhaps a more OS format
could be used? As these are simple images why not just png?)
- All source code has headers
- Can't compile from source

Minor issues
- No need to mention any of the JS libraries in NOTICE as they are MIT licensed [1]
- It may be the that two power point files have embedded fonts as they contain "Copyright
2007 Apple Inc., all rights reserved"?

Currently I'm unable to get the source package to compile (on OSX using Java 1.7).

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [  0.862 s]
[INFO] Lens .............................................. SUCCESS [  0.029 s]
[INFO] Lens API .......................................... SUCCESS [  0.518 s]
[INFO] Lens API for server and extensions ................ SUCCESS [  1.246 s]
[INFO] Lens Cube ......................................... SUCCESS [  0.236 s]
[INFO] Lens DB storage ................................... SUCCESS [  0.140 s]
[INFO] Lens Query Library ................................ SUCCESS [  0.127 s]
[INFO] Lens Hive Driver .................................. SUCCESS [  0.657 s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [  0.157 s]
[INFO] Lens Server ....................................... FAILURE [ 11.472 s]
[INFO] Lens client ....................................... SKIPPED
[INFO] Lens CLI .......................................... SKIPPED
[INFO] Lens Examples ..................................... SKIPPED
[INFO] Lens Distribution ................................. SKIPPED
[INFO] Lens ML Lib ....................................... SKIPPED
[INFO] Lens Regression ................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16.060 s
[INFO] Finished at: 2015-02-28T10:48:24+10:00
[INFO] Final Memory: 24M/58M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project lens-server: Could not resolve dependencies for
project org.apache.lens:lens-server:war:2.0.1-beta-incubating: Could not find artifact org.apache.lens:lens-driver-hive:jar:tests:2.0.1-beta-incubating
in inmobi.repo (https://github.com/InMobi/mvn-repo/raw/master/releases) -> [Help 1]

Why does it appear that the Apache lens artefacts are publicly deployed here [2], are these
pre Apache incubator versions of the software?

For the binary distribution (again all minor issues).
-  I'm concerned by the inclusion of  LICENSE-GPLv3 and LICENSE-LGPL file. I assume these
are there because of dual licensing. They should probably be removed.
- NOTICE contain several items that shouldn't be there (anything MIT licensed for instance)
- NOTICE may be missing required notice from included NOTICE file (I didn't check in detail,
but would be surprised if it was empty with all those jars)
- LICENSE is missing licences for opalliance-1.0.jar and xz-1.0.jar (public domain). Unless
stated the assumption would be that they are Apache licensed/copyright Apache.

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
2. https://github.com/InMobi/mvn-repo/tree/master/releases/org/apache/lens
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message