Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
Received-SPF: error (athena.apache.org: local policy)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: [VOTE] Release Apache Brooklyn 0.7.0-M2-incubating [rc4]
From: Justin Mclean <justin@classsoftware.com>
In-Reply-To: 
 <CABQFKi02fCQhLbBCwWipWwPuyNfq5unLMFNt0KLKY-Mi+iMTWQ@mail.gmail.com>
Date: Sat, 27 Dec 2014 15:09:19 +1100
Content-Transfer-Encoding: quoted-printable
Message-Id: <D6099506-9EDB-4743-882A-FAFEEFBD2869@classsoftware.com>
References: 
 <CABQFKi02fCQhLbBCwWipWwPuyNfq5unLMFNt0KLKY-Mi+iMTWQ@mail.gmail.com>
To: general@incubator.apache.org

Hi,

+1 binding

I checked:
- hashes and MD5 fine
- DISCLAIMER exists
- artefact has incubating in file name
- LICENSE and NOTICE good (checked all items)
- No unexpected binary files in source release
- Most source code has correct headers (see below)
- Can compile from source

A few minor things missing from LICENSE, can you add these in the next =
release.
- superfish (MIT)
- JQuery slideto looks be MIT not Apache to me. [1]

Some other minor issues you might want to change for next release:
- There some java files under =
usage/archetypes/quickstart/src/brooklyn-sample that are missing Apache =
headers
- Can usage/jsgui/src/main/webapp/assets/images/Sorting icons.psd be put =
a more OS friendly format?

Thanks,
Justin

1. =
http://web.archive.org/web/20121119015407/http://jesseprice.com/jquery-sli=
de-to-plugin/=

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org