Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: [VOTE] Release of Apache Falcon 0.5-incubating - RC5
From: Justin Mclean <justin@classsoftware.com>
In-Reply-To: 
 <CAOGo0VYY0dSOrPNXubE1gZpNfO74KnfDkMb5dhjrNROxZ1O=9A@mail.gmail.com>
Date: Mon, 15 Sep 2014 06:59:31 +1000
Content-Transfer-Encoding: quoted-printable
Message-Id: <19512409-1631-41B4-89F7-85C2EB15880D@classsoftware.com>
References: <BLU179-W4635CB0EDA7F8C86C013E9A4CB0@phx.gbl>
 <CAOGo0VYY0dSOrPNXubE1gZpNfO74KnfDkMb5dhjrNROxZ1O=9A@mail.gmail.com>
To: general@incubator.apache.org

Hi,

Sorry but it's -1 (binding) from me.  Everything is good except that the =
jQuery has had an Apache license header added to it.  (in =
./html5-ui/js/jquery-1.11.0.min.js) If other incubator members think =
this isn't a blocker I'll change my vote.

jQuery is MIT licensed [1] so should be treated the same as the other =
bundled MIT bits and put in LICENSE. (If the license could be changed to =
Apache then this would needed to have been mentioned in NOTICE.)

Here's what I checked:
- File name contain incubating
- DISCLAIMER exists
- LICENSE and NOTICE good (older version of bootstrap is handled =
correctly, if newer version is used than LICENSE would need to change)
- All source files contain Apache header
- No unexpected binary files in release
- Can compile from source=20

Minor issues you may want to fix for the next release.
- License has:
  This product bundles dust-helpers 1.2.0, which is available under a=20
  MIT license. For details, see docs/license/dust-LICENSE.txt
 =20
 Which should be this:
  This product bundles dust-helpers 1.2.0, which is available under a=20
  MIT license. For details, see docs/license/dust-helpers-LICENSE.txt

- A RELEASE_NOTES listing changes from previous version/list of bugs =
fixed would be helpful.
- To compile you need to set MVN_CMD, add this to installation =
instructions.
- Looks like a packaging issue in the process directory with a directory =
named "${system.lib.location}"

Would also be nice if at all possible if you could compile with Java 1.7 =
rather than 1.6 as 1.6 has been EOLed

Thanks,
Justin

1. https://jquery.org/license/=

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org