incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache Flink 0.6-incubating
Date Tue, 19 Aug 2014 01:50:56 GMT
Hi,

+1 binding, but only because it's your first release, NOTICE and LICENSE issues need to fixed
for the next release.

I checked:
- vote good
- incubating in release package name
- sig and md5 hashes good
- DISCLAIMER exits
- NOTICE and LICENSE are not correct (see below for issues)
- source files have correct header
- no binary files in release
- can compile from source
- tests pass

LICENSE and NOTICE  file issues:
- There's no need to include software that is not bundled, there's too many bits of software
listed that are not bundled
- Looks like several MIT/BSD licensed bundled bits are missing eg Bootstrap, JQuery, JCanvas,
Flot and D3
- Looks like you need separate LICENSE and NOTICE file for source and binary artefacts. Again
only included/bundled bits need to go in LICENSE/NOTICE.

You may also want to consider adding "apache" to the artefact name (not required).

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message