incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Apache DeviceMap .Net clients 1.0.0
Date Wed, 30 Jul 2014 22:19:59 GMT
Hi,

+1 binding

- vote good
- incubating in artefact name
- DISCLAIMER exists
- LICENCE and NOTICE good
- most file have Apache headers (see below)
- no binary files in release
- didn't test as don't have environment to test

These files do not have Apache headers:
  DeviceMap/App.config
  DeviceMap/DeviceMap.csproj
  DeviceMap/Properties/AssemblyInfo.cs
  DeviceMapConsole/App.config
  DeviceMapConsole/DeviceMapConsole.csproj
  DeviceMapConsole/Properties/AssemblyInfo.cs
  DeviceMapConsole/ua_strings.txt
  DeviceMap.sln

You may want to consider fixing for the next release:
- add apache headers to .config, .csproj, .cs, .sln and ua_strings.txt files
- year in NOTICE is wrong (should be 2014)
- host RC on Apache hardware when voting  - should be here https://dist.apache.org/repos/dist/dev/incubator/devicemap/

Thanks,
Justin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message