Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAOGo0VZQT8BRu4aZP3zdneU5rd+8S4jR9V9NoBTCg1SYg2wYvQ@mail.gmail.com>
References: 
 <CAAF1Jdi=3MBQGq5b5Jdh8Rp=DZgWy24UOy9CvWeWMLNeUvQuSA@mail.gmail.com>
 <CAOGo0VZnqxjAmZL-Qxvo7_CCKv0o+vJbNGVNktPoSTqWZeFjmw@mail.gmail.com>
 <CA+RK=_CnQjE4aeZnozLxVyzTLDcbujU1hBhHie4z8ZE1tn_UYw@mail.gmail.com>
 <CAOGo0VYL_uOdFtmgvFW_NTx01jSLsv-mRq5FEuDbpy_Ba=vPMQ@mail.gmail.com>
 <CA+RK=_AbatoqEpTZtLM+rZS+rpwgVTpS3NXen088CJOw4h_mcQ@mail.gmail.com>
 <CAOGo0VYY51O_LyAz+-DXtiT8ggdXa5KDFwZyHZFN2f=XryEtCQ@mail.gmail.com>
 <CA+RK=_AwAjuVZaqtg_Zbw0LX0CQqNNZLC4XPmg_b5Mu0humuHw@mail.gmail.com>
 <CAAF1Jdh1FzehytL_mJz3j9LioW8Zofx8vWrbtuCpe8SHSOJf7g@mail.gmail.com>
 <CAOGo0VZ6mANttf9eOtqg-9MACH-cBZqTzDUC4i6yk_QjbRms-g@mail.gmail.com>
 <CAAF1JdjDAgULNSp3nqGB0O8JFE0Mc+Q-xJGi4gM1GVV_txu_fA@mail.gmail.com>
 <CAOGo0VZQT8BRu4aZP3zdneU5rd+8S4jR9V9NoBTCg1SYg2wYvQ@mail.gmail.com>
From: Andrew Purtell <apurtell@apache.org>
Date: Tue, 25 Mar 2014 17:35:40 -0700
Message-ID: 
 <CA+RK=_Cpa8N0BThF-a=4k+OpL3aYTMr-7jT73uDEnoxK8cb6wg@mail.gmail.com>
Subject: Re: [VOTE] Release of Apache Phoenix 3.0.0 incubating RC1
To: "general@incubator.apache.org" <general@incubator.apache.org>
Content-Type: multipart/alternative; boundary=001a11c25d364d037c04f577a8a3

--001a11c25d364d037c04f577a8a3
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Mar 25, 2014 at 4:25 PM, sebb <sebbaz@gmail.com> wrote:

> > Yes, we bundle ANTLR in our binary distribution. Most of the other items
> > are pulled in based on the transitive dependencies of other jars we've
> > bundled in our binary distribution.
>
> I see now why I did not notice the 3rd party binaries.
> They seem to have been merged into jars which look like phoenix code -
> and indeed also contain phoenix code.
>
> That is a very non-standard way to do things, and I think could
> mislead end-users as to the provenance of the code.
>
> It's OK to bundle separate jars in a binary release (assuming
> licensing etc is OK), but I don't think it's OK to merge 3rd party
> code with ASF code in a single jar.
> Apart from anything, that will play havoc with Maven and possibly
> other dependency management systems.


I believe this is done because Phoenix is a JDBC client, and JDBC drivers
are usually packaged as single JARs for convenience. James could confirm or
refute. I concluded this is acceptable practice having seen it elsewhere at
Apache, for example in Apache Pig, their convenience fatjar artifact.


-- 
Best regards,

   - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)

--001a11c25d364d037c04f577a8a3--