incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jake Farrell <jfarr...@apache.org>
Subject Re: [VOTE] Graduation of Apache Spark from the Incubator
Date Thu, 06 Feb 2014 17:53:30 GMT
The webhooks are in place to send pr notifications from github to the
dev@lists, the problem is that comments do not get sent only the
actions of
opening and closing of the pr are sent.

-Jake


On Thu, Feb 6, 2014 at 12:08 PM, Michael Joyce <joyce@apache.org> wrote:

> How is doing a review on Github any different than doing a review on Review
> Board? If there's concern that work on Github isn't being adequately
> mirrored on the mailing lists then that sounds like an Infra problem to me.
> There are plenty of hooks [1] that makes this easy to do and, if I'm not
> mistaken, pull requests through Github are already supposed to mail dev@.
> I
> would assume that any comment on them should as well.
>
>
> [1] http://developer.github.com/v3/repos/hooks/
>
>
> -- Joyce
>
>
> On Thu, Feb 6, 2014 at 1:22 AM, David Nalley <david@gnsa.us> wrote:
>
> > >
> > > If you look at the GitHub code reviews (
> > https://github.com/apache/incubator-spark/pulls), you'll see that lots
> of
> > people are contributing to reviewing. But I agree that the new committer
> > onboarding process should include having them do a test commit.
> > >
> >
> > Matei:
> >
> > Reviews being done on github causes me a bit of concern. Generally
> > dev@ should be the nexus for a project, and most of the projects that
> > have github in the workflow ensure that pull requests get sent to dev@
> > so the discussions, reviews, and patches themselves are seen and
> > archived there.
> >
> > I see that one of your mentors brought up similar concerns about this
> > (as well as where discussions on strategy or roadmap happen) yesterday
> > on dev@ - that doesn't leave me with warm fuzzy assurance that the
> > project groks the Apache way.
> >
> > --David
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message