incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <>
Subject Re: [VOTE] Release of Apache MRQL 0.9.0 incubating
Date Thu, 26 Sep 2013 16:45:20 GMT
On 24 September 2013 13:44, Leonidas Fegaras <> wrote:
> Hello,
> This is a call for a vote on Apache MRQL 0.9.0 incubating. MRQL is a
> query processing and optimization system for large-scale, distributed
> data analysis, built on top of Apache Hadoop, Hama, and Spark.
> This is our first release. A vote was held on the MRQL developer
> mailing list and it passed with three +1 votes (plus one late vote),
> and zero -1 or 0 votes (see the vote thread [1] and result thread [2]),
> and now requires a vote on The vote will
> be open for 72 hours (it will close on Friday 27/Sep/2013 at 1pm GMT)
> and passes if a majority of at least three +1 IPMC votes are cast.
> [ ] +1 Release this package as Apache MRQL 0.9.0-incubating
> [ ] -1 Do not release this package because...
> A staged Maven repository is available for review at:
> You are voting only for the source distribution.
> The source tar ball is available at:
> The release candidate consists of the following source distribution
> archives:
> - mrql-src-dist-0.9.0-incubating.[zip|tar.gz]
>   SHA1 of TGZ: 4b5c6c2df32881b77633303435cb0c99856105cd
>   SHA1 of ZIP: edae1009a5ef7a7613f4da4d2d46e1c9339cb70f
> You can compile the sources using 'mvn package'.
> In addition, the following supplementary binary distributions are provided
> for user convenience at:
> The binary distribution archives are:
> - mrql-bin-dist-0.9.0-incubating.[zip|tar.gz]
>   SHA1 of TGZ: 27a1c569a0da333a22da260b07356673b81f539c
>   SHA1 of ZIP: 6afdeb2640e6b3a31a97e44a0b5e585e6ade62ac
> The release candidate has been signed through the key 798764F1 in:
> The release candidate is based on the sources tagged with
> MRQL-0.9.0-incubating-RC1:

That does not seem to be the correct tag, because the pom versions
include -SNAPSHOT in them.

> RAT output:
> Suitable name search:

The vote e-mail includes the hashes for tags and archives which is
excellent, as it ties the vote to the items being voted on.
So it's unfortunate that the tag does not agree with the source archive.

Sigs and hashes seem OK to me.

The <name> and <description> entries in the POMs should all start
Apache MRQL so it is clear that they are part of the Apache MRQL
This is necessary for clear branding. Also the <name> affects the
generated NOTICE files under META-INF.
These are currently invalid.

It's a bit confusing to have artifact id of "gen" when all the other
ids include MRQL or mrql.

> Note: The NOTICE includes the 3rd party copyright notices for JLine
> and CUP because the JLine and the CUP runtime libraries are bundled in
> the jar files in the MRQL binary distribution (files lib/*.jar).
> This was required because the MRQL jar files must contain all the
> dependencies in order to run on Hadoop and Hama.

It's OK to bundle 3rd party jars (assuming that the license allows us
to do so, so no GPL for example).
However, the NOTICE and LICENSE files must only refer to the enclosing entity.
Since the source archive does not contain CUP and JLine its N&L files
must not include references to them.
Likewise the top level N&L files in the Git repo should only refer to
files actually contained in the repo.

Also, the NOTICE file looks wrong even for the binary jar; at *most*
two or 3 lines are needed for each external inclusion.
The licences must either be appended to the LICENSE file or you can
store them in separate files which are linked from the main LICENSE

Some of the POMs in the Nexus staging repo appear to have lost their AL headers.

> To learn more about Apache MRQL, please visit:
> Thanks,
> Leonidas Fegaras
> [1]
> [2]
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> For additional commands, e-mail:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message