incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release of Apache Allura (incubating) v1.0.0
Date Mon, 16 Sep 2013 22:43:43 GMT
On 28 August 2013 23:04, Cory Johns <johnsca@gmail.com> wrote:
> Hello,
>
> This is a call for a vote on Apache Allura 1.0.0 incubating. This is our
> first release.
>
> A vote was held on developer mailing list and it passed with 9 +1's, and 0
> -1's or +0's (vote thread [1], discussion thread [2] which some of the
> votes were cast on, due to some confusion, and result thread [3]), and now
> requires  a vote on general@incubator.apache.org.
>
> Source tar ball and signature are available at:
> https://dist.apache.org/repos/dist/dev/incubator/allura/

The NOTICE file has leading spaces on every line; these should be
removed for a future release.

The parent directory in the archive is called "allura"; generally
projects include the version information, e.g.
"allura-1.0.0-incubating".
That makes it easier to distinguish unpacked archives. Not a release blocker.

There are several 3rd party source items mentioned in the top level NOTICE fie.
However I could not find any corresponding LICENSE files.
Every file needs to be covered by a LICENSE file; not all licenses
require a mention in the NOTICE file, so there is a mismatch here.

I now see that there are multiple copies of the NOTICE and LICENSE
files with differing content.
This is very confusing for the end user (and the reviewer!)

There should be a single NOTICE and LICENSE file in the parent
directory (allura/) which covers all the contents (and nothing else).

I think that is a release blocker.

In fact it looks like the file allura/Allura/LICENSE is intended to be
the file for the entire source release.
It should be in the parent directory.

Also, it looks to me as though some of the NOTICE content is not
necessary; it's vital that only required content is included.
See for example:
http://www.apache.org/dev/licensing-howto.html#mod-notice

I suspect most if not all of the attrributions in the NOTICE file are
not required, and therefore must be removed.

There seem to be some files without the appropriate license header, for example:

allura/AlluraTest/jslint/Makefile
allura/Allura/allura/controllers/controller.template
allura/Allura/allura/public/nf/css/blueprint/src/forms.css
allura/Allura/allura/public/nf/css/blueprint/src/grid.css
allura/Allura/allura/public/nf/css/blueprint/src/ie.css
allura/Allura/allura/public/nf/css/blueprint/src/print.css
allura/Allura/allura/public/nf/css/blueprint/src/reset.css
allura/Allura/allura/public/nf/css/blueprint/src/typography.css

There are other source files without any apparent license header.

> Checksums:
> MD5: 31b9ed4af10b28f4219c00af8592d61c  allura-incubating-1.0.0.tar.gz
> SHA1: 0ca70edeaa497261d7f6cfbedde6cab7a20ec072
> allura-incubating-1.0.0.tar.gz
> SHA512: 38a921da57c3e53085869aa4ea9690e11247161d6351e8235907d28f1497a597f8df7fb41326cfa1c96700a8ed7cf8b79d60520784ee465358d3cccc047680e5
> allura-incubating-1.0.0.tar.gz
>
> The release has been signed with keys (9BB3CE70 and 449C78B1):
> http://pgp.mit.edu:11371/pks/lookup?op=vindex&search=0x56F0526F9BB3CE70
> http://pgp.mit.edu:11371/pks/lookup?op=vindex&search=0xDB6E071B449C78B1
>
> Source corresponding to this release can be found at
> https://git-wip-us.apache.org/repos/asf?p=incubator-allura.git;a=shortlog;h=refs/tags/asf_release_1.0.0
>
> Vote will be open for at least 1 week (4/Sep/2013 12PM IST) to allow for it
> being our first release.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thanks & Regards
> Cory Johns

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message