incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@gmail.com>
Subject Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Date Tue, 04 Jun 2013 00:12:20 GMT
As I said, it does look good. But I don't see the LinkedIn Copyright
in any files under tools/. The copyright/license header should remain
in the files that you copied into our repos. It is impossible to tell
what is from LinkedIn.

Cheers,
-g

On Sun, Jun 2, 2013 at 11:08 PM, Alan Cabrera <list@toolazydogs.com> wrote:
>
> On Jun 2, 2013, at 7:45 PM, Kevan Miller <kevan.miller@gmail.com> wrote:
>
>>
>> On Jun 2, 2013, at 10:09 PM, Alan Cabrera <list@toolazydogs.com> wrote:
>>
>>>
>>> On Jun 2, 2013, at 5:29 PM, sebb <sebbaz@gmail.com> wrote:
>>>
>>>> On 3 June 2013 00:37, Alan Cabrera <list@toolazydogs.com> wrote:
>>>>>
>>>>> On Jun 2, 2013, at 4:01 PM, sebb <sebbaz@gmail.com> wrote:
>>>>>
>>>>>>> Modified: incubator/public/trunk/tools/NOTICE.txt
>>>>>>> URL: http://svn.apache.org/viewvc/incubator/public/trunk/tools/NOTICE.txt?rev=1488735&r1=1488734&r2=1488735&view=diff
>>>>>>> ==============================================================================
>>>>>>> --- incubator/public/trunk/tools/NOTICE.txt (original)
>>>>>>> +++ incubator/public/trunk/tools/NOTICE.txt Sun Jun  2 16:21:24
2013
>>>>>>> @@ -1,5 +1,21 @@
>>>>>>> =========================================================================
>>>>>>> ==  NOTICE file corresponding to section 4(d) of the Apache License,
  ==
>>>>>>> -==  Version 1.0.0, in this case for the LiveTribe Utilities
           ==
>>>>>>> +==  Version 2.0.0, in this case for the ASF Incubator tools
           ==
>>>>>>> ==  distribution.                                           
          ==
>>>>>>> =========================================================================
>>>>>>> +
>>>>>>> +This distribution contains code from the LinkedIn Corporation:
>>>>>>> +
>>>>>>> + Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>>>>>> +
>>>>>>> + Licensed under the Apache License, Version 2.0 (the "License");
>>>>>>> + you may not use this file except in compliance with the License.
>>>>>>> + You may obtain a copy of the License at
>>>>>>> +
>>>>>>> +     http://www.apache.org/licenses/LICENSE-2.0
>>>>>>> +
>>>>>>> + Unless required by applicable law or agreed to in writing,
software
>>>>>>> + distributed under the License is distributed on an "AS IS"
BASIS,
>>>>>>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
or implied.
>>>>>>> + See the License for the specific language governing permissions
and
>>>>>>> + limitations under the License.
>>>>>>
>>>>>> That does not look like a standard NOTICE file.
>>>>>> The part between === should not be present, and the AL 2.0 should
not
>>>>>> be there either.
>>>>>>
>>>>>> Is the notice entry even required by the Linked In license?
>>>>>>
>>>>>> Remember that NOTICE files are like poems - they are only correct
when
>>>>>> nothing more can be removed!
>>>>>
>>>>> Would this suffice:
>>>>>
>>>>> <begin>
>>>>> This distribution contains code from the LinkedIn Corporation:
>>>>>
>>>>> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>>>> <end>j
>>>>
>>>> IMO, no.
>>>>
>>>> It's not a standard NOTICE file - the ASF header is missing.
>>>
>>>
>>> Can you point to a canonical example for me to emulate?
>>
>> How about the following:
>>
>> http://www.apache.org/legal/src-headers.html#notice
>> and
>> http://www.apache.org/dev/licensing-howto.html
>
>
> Apache Incubator tools
> Copyright 2013 The Apache Software Foundation
>
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
>
> This distribution contains code from the LinkedIn Corporation:
>
>     Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>     Licensed under the Apache License, Version 2.0
>
>
> WDYT?
>
>
> Regards,
> Alan
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message