incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Grobmeier <grobme...@gmail.com>
Subject Re: [VOTE] Release Onami Parent 1 RC2
Date Thu, 27 Dec 2012 09:49:43 GMT
Hi again,

thanks for your efforts! I appreciate it.

I now what you mean now, but I think its pretty normal. Please look at
what I did with Commons Compress:

$ java -classpath commons-compress-1.4.1.jar
org.apache.commons.compress.archivers.Lister
org.apache.felix.configadmin-1.6.0-source-release.zip
Analysing org.apache.felix.configadmin-1.6.0-source-release.zip
Created org.apache.commons.compress.archivers.zip.ZipArchiveInputStream@2e8f4fb3
org.apache.felix.configadmin-1.6.0/
org.apache.felix.configadmin-1.6.0/src/
org.apache.felix.configadmin-1.6.0/src/main/
org.apache.felix.configadmin-1.6.0/src/main/appended-resources/
org.apache.felix.configadmin-1.6.0/src/main/appended-resources/META-INF/
org.apache.felix.configadmin-1.6.0/src/main/java/
...

Felix configadmin does use the same format.

The binary of Commons Compress has it too:

$ java -classpath commons-compress-1.4.1.jar
org.apache.commons.compress.archivers.Lister
commons-compress-1.4.1-bin.zip
Analysing commons-compress-1.4.1-bin.zip
Created org.apache.commons.compress.archivers.zip.ZipArchiveInputStream@7bd63e39
commons-compress-1.4.1/
commons-compress-1.4.1/LICENSE.txt
commons-compress-1.4.1/NOTICE.txt
commons-compress-1.4.1/README.txt
commons-compress-1.4.1/RELEASE-NOTES.txt
commons-compress-1.4.1/commons-compress-1.4.1-tests.jar
commons-compress-1.4.1/commons-compress-1.4.1.jar
...

And of course the Apache Parent POM.

So either all of these packages are "wrong" or it seems it is
acceptable usage. Actually I think it is fine: it is the only folder
which becomes extracted for me everything inside this folder is
"root".


On Thu, Dec 27, 2012 at 8:41 AM, Marcel Offermans
<marcel.offermans@luminis.nl> wrote:
>>> A question about the contents of the NOTICE file, can you explain why you included
the line:
>>> "Copyright 2010-2012 The 99 Software Foundation" ?
>>
>> hm I think the original package maintainer left this in the NOTICE
>> file. Before Onami came to the Incubator, it was maintained by "99
>> Software Foundation" (which is not really a registered foundation).
>> Most likely he thinks that the history should be kept in the NOTICE
>> file like we do sometimes with attributing people who donated a few
>> classes.
>
> It should only be in the notice if Onami contains third-party software that requires
you mention it [1]. Since this is code that was donated to Apache, I don't think that applies,
so you should leave it out.

Makes sense to me too. Do you consider it a blocker?
I looked at it as some kind of attribution, like here:
http://svn.apache.org/repos/asf/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStream.java
Or similar as to the discouraged @author tags.
Don't get me wrong, I am all for removing it and will discuss it on
dev list. I am just thinking if this should block the release or not.

Cheers
Christian

> Greetings, Marcel
>
> [1] http://apache.org/legal/resolved.html#required-third-party-notices
>
>



--
http://www.grobmeier.de
https://www.timeandbill.de

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message