incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Grobmeier <grobme...@gmail.com>
Subject Re: [VOTE] JSPWiki version 2.9.0-incubating
Date Sun, 07 Oct 2012 19:30:41 GMT
Hello,

i'm sorry to -1 your release :-(

Please see:
http://www.apache.org/legal/src-headers.html#headers

I have found a lot of code like in the the src package /src/webdocs/Captcha.jsp
which are missing header licenses. I saw it is in the .java files, but
they should be basically in every file we release (including jsp)

Also export.sh misses headers.

In the headers of the .java files is: JSPWiki - a JSP-based WikiWiki clone.
Not sure if this is a blocker, but you should use the full name
"Apache JSPWiki" instead of only "JSPWiki". Personally I would get rid
of this line actually, but i think it is up to you.

Example:
https://svn.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_9_0_incubating_rc3/src/org/apache/catalina/util/HexUtils.java

I have not tested signatures yet.

In other projects sometimes the website is being voted on together
with the releases. Is it not the case with JSPWiki?

On another note, I agree with Ross. Your mentors should have told you
that and they should have voted already. Not sure if how the overall
situation on your daily project life is. If you feel that you would
need more mentor support, please write a separate e-mail to this list.
I have only looked at this e-mail as it was open for a couple of days
without much responses.

Best regards,
Christian

On Thu, Sep 27, 2012 at 8:11 PM, Juan Pablo Santos Rodríguez
<juanpablo@apache.org> wrote:
> Hi,
>
> This is a call for a vote on releasing the following candidate as Apache
> JSPWiki version 2.9.0-incubating.
> This will be our first release. A vote was held on the developer mailing
> list (http://s.apache.org/dzM) and
> passed with 10 +1s (* denoting PPMC):
>
> Janne Jalkannen*
> Florian Holeczek*
> Harry Metske*
> Andrew Jaquith*
> Dirk Frederickx*
> Juan Pablo Santos Rodríguez*
> Fabian Haupt
> Michael Gerzabek
> Christophe Dupriez
> Roberto Venturi
>
> We need at least 3 IPMC votes.
>
> This release fixes the following issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732&version=12319521
>
> Source and binary files:
> http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
>
> The tag to be voted upon:
> https://svn.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_9_0_incubating_rc3
>
> JSPWiki's KEYS file containing PGP keys we use to sign the release:
> http://www.apache.org/dist/incubator/jspwiki/KEYS
>
>
> Please download, test, and vote by 72 hours from now.
>
> [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why)
>
>
> Thanks,
> juan pablo



-- 
http://www.grobmeier.de
https://www.timeandbill.de

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message