incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benson Margulies <bimargul...@gmail.com>
Subject Re: [VOTE] Apache Cordova (incubating) 2.1.0
Date Mon, 24 Sep 2012 21:16:11 GMT
On Mon, Sep 24, 2012 at 5:11 PM, Noah Slater <nslater@tumbolia.org> wrote:
> Speaking as CouchDB's RM, I would consider missing license headers a
> blocker.
>
> Are rules more lax within the Incubator?

In the incubator, minor problems of this sort are non-blocking. They
per-file notices are suspenders over top of the belt, which is the
LICENSE file.

>
> On Mon, Sep 24, 2012 at 7:23 PM, Jukka Zitting <jukka.zitting@gmail.com>wrote:
>
>> Hi,
>>
>> On Mon, Sep 24, 2012 at 5:21 PM, Bertrand Delacretaz
>> <bdelacretaz@apache.org> wrote:
>> > I had a look and things mostly look good, but
>> >
>> > $ grep -L "Apache Software Foundation" $(find . -name *.java)
>> >
>> > finds a number of .java and .js files that are missing the Apache License
>> > header, for example under ./incubator-cordova-js.zip/lib/common/plugin/
>> >
>> > I haven't checked files with other extensions - did the Cordova team run
>> > RAT to check those headers?
>>
>> Yes, that's one of the issues that came up during the review [1]. It's
>> already being resolved [2] for the next release.
>>
>> The community did a similar exercise already earlier [3], but some of
>> the more recent changes brought in new files without the copyright
>> headers. That's something to improve before graduation, but personally
>> I don't see this as a blocker for the present release.
>>
>> [1] http://markmail.org/message/53m3msdrlclbyf56
>> [2] https://issues.apache.org/jira/browse/CB-1477
>> [3] https://issues.apache.org/jira/browse/CB-639
>>
>> BR,
>>
>> Jukka Zitting
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
>
>
> --
> NS

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message